Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Unified Diff: net/cert/internal/trust_store_collection_unittest.cc

Issue 2805213004: Refactor how net/data/verify_certificate_chain_unittest/* (Closed)
Patch Set: fix android Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/cert/internal/trust_store_collection_unittest.cc
diff --git a/net/cert/internal/trust_store_collection_unittest.cc b/net/cert/internal/trust_store_collection_unittest.cc
index 15868c221409cc418984743d4e883b23597aa05d..20f73a38d9b344797f8ef89052bc271b6b9178fd 100644
--- a/net/cert/internal/trust_store_collection_unittest.cc
+++ b/net/cert/internal/trust_store_collection_unittest.cc
@@ -16,12 +16,9 @@ class TrustStoreCollectionTest : public testing::Test {
public:
void SetUp() override {
ParsedCertificateList chain;
-
- VerifyCertChainTest test;
- ReadVerifyCertChainTestFromFile(
- "net/data/verify_certificate_chain_unittest/key-rollover-oldchain.pem",
- &test);
- chain = test.chain;
+ ASSERT_TRUE(ReadCertChainFromFile(
+ "net/data/verify_certificate_chain_unittest/key-rollover/oldchain.pem",
+ &chain));
ASSERT_EQ(3U, chain.size());
target_ = chain[0];
@@ -31,11 +28,10 @@ class TrustStoreCollectionTest : public testing::Test {
ASSERT_TRUE(oldintermediate_);
ASSERT_TRUE(oldroot_);
- ReadVerifyCertChainTestFromFile(
- "net/data/verify_certificate_chain_unittest/"
- "key-rollover-longrolloverchain.pem",
- &test);
- chain = test.chain;
+ ASSERT_TRUE(
+ ReadCertChainFromFile("net/data/verify_certificate_chain_unittest/"
+ "key-rollover/longrolloverchain.pem",
+ &chain));
ASSERT_EQ(5U, chain.size());
newintermediate_ = chain[1];

Powered by Google App Engine
This is Rietveld 408576698