Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Unified Diff: net/data/verify_certificate_chain_unittest/target-unknown-critical-extension/generate-chains.py

Issue 2805213004: Refactor how net/data/verify_certificate_chain_unittest/* (Closed)
Patch Set: fix android Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/data/verify_certificate_chain_unittest/target-unknown-critical-extension/generate-chains.py
diff --git a/net/data/verify_certificate_chain_unittest/generate-target-unknown-critical-extension.py b/net/data/verify_certificate_chain_unittest/target-unknown-critical-extension/generate-chains.py
similarity index 69%
rename from net/data/verify_certificate_chain_unittest/generate-target-unknown-critical-extension.py
rename to net/data/verify_certificate_chain_unittest/target-unknown-critical-extension/generate-chains.py
index 375522c1b41e8cb3dc894e993ae6dd79d975a040..f1d43a4dbb736f9b41b87fdb727933c911ef1f84 100755
--- a/net/data/verify_certificate_chain_unittest/generate-target-unknown-critical-extension.py
+++ b/net/data/verify_certificate_chain_unittest/target-unknown-critical-extension/generate-chains.py
@@ -8,6 +8,9 @@ certificate has an unknown X.509v3 extension (OID=1.2.3.4) that is marked as
critical. Verifying this certificate chain is expected to fail because there is
an unrecognized critical extension."""
+import sys
+sys.path += ['..']
+
import common
# Self-signed root certificate (used as trust anchor).
@@ -21,17 +24,5 @@ target = common.create_end_entity_certificate('Target', intermediate)
target.get_extensions().add_property('1.2.3.4',
'critical,DER:01:02:03:04')
-chain = [target, intermediate]
-trusted = common.TrustAnchor(root, constrained=False)
-time = common.DEFAULT_TIME
-key_purpose = common.DEFAULT_KEY_PURPOSE
-verify_result = False
-errors = """----- Certificate i=0 (CN=Target) -----
-ERROR: Unconsumed critical extension
- oid: 2A0304
- value: 01020304
-
-"""
-
-common.write_test_file(__doc__, chain, trusted, time, key_purpose,
- verify_result, errors)
+chain = [target, intermediate, root]
+common.write_chain(__doc__, chain, 'chain.pem')

Powered by Google App Engine
This is Rietveld 408576698