Make ZIP archiver a component extension.

chrome/browser/extensions/component_extensions_whitelist/whitelist.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/component_extensions_whitelist/whitelist.h"
 
 #include <stddef.h>
 
 #include "base/logging.h"
 #include "base/macros.h"
@@ skipping 23 matching lines @@
     extension_misc::kInAppPaymentsSupportAppId,
 #if defined(ENABLE_MEDIA_ROUTER)
     extension_misc::kMediaRouterStableExtensionId,
 #endif  // defined(ENABLE_MEDIA_ROUTER)
     extension_misc::kPdfExtensionId,
 #if defined(OS_CHROMEOS)
     extension_misc::kChromeVoxExtensionId,
     extension_misc::kSelectToSpeakExtensionId,
     extension_misc::kSpeechSynthesisExtensionId,
     extension_misc::kSwitchAccessExtensionId,
     extension_misc::kZIPUnpackerExtensionId,

[yawano, 2017/04/20 01:43:16]

IIUC, we need to add ZipArchiverExtensionId here.
ComponentLoader::Add(manifest_resource_id, ...) falls into
ComponentLoader::Add(parsed_manifest, ...) and there is a check by extension id
in the function. As I cannot upload a patch to this CL, I'll download this CL
and re-upload to another CL.

[brettw, 2017/04/20 03:23:17]

Don't we need this to be done before submitting?

[yawano, 2017/04/20 03:52:24]

No, we don't need to do it. ComponentLoader::Add(parsed_manifest, ...) is called
with skip_whitelist=true. In that case, whitelist check for extension id is
passed.

Also if I check other component extensions (e.g. file manager, gallery), they
only have their entries only in resource id list.

 #endif
   };
 
   for (size_t i = 0; i < arraysize(kAllowed); ++i) {
     if (extension_id == kAllowed[i])
       return true;
   }
 
 #if BUILDFLAG(ENABLE_APP_LIST) && defined(OS_CHROMEOS)
   std::string google_now_extension_id;
@@ skipping 50 matching lines @@
     case IDR_CONNECTIVITY_DIAGNOSTICS_LAUNCHER_MANIFEST:
     case IDR_CONNECTIVITY_DIAGNOSTICS_MANIFEST:
     case IDR_CROSH_BUILTIN_MANIFEST:
     case IDR_DEMO_APP_MANIFEST:
     case IDR_EASY_UNLOCK_MANIFEST:
     case IDR_EASY_UNLOCK_MANIFEST_SIGNIN:
     case IDR_ECHO_MANIFEST:
     case IDR_FILEMANAGER_MANIFEST:
     case IDR_FIRST_RUN_DIALOG_MANIFEST:
     case IDR_GALLERY_MANIFEST:
+    case IDR_ZIP_ARCHIVER_MANIFEST:
     case IDR_KEYBOARD_MANIFEST:
     case IDR_MOBILE_MANIFEST:
     case IDR_VIDEO_PLAYER_MANIFEST:
     case IDR_WALLPAPERMANAGER_MANIFEST:
 #if defined(GOOGLE_CHROME_BUILD)
     case IDR_GENIUS_APP_MANIFEST:
     case IDR_HELP_MANIFEST:
     case IDR_QUICKOFFICE_MANIFEST:
 #endif  // defined(GOOGLE_CHROME_BUILD)
 #endif  // defined(OS_CHROMEOS)
       return true;
   }
 
   LOG(ERROR) << "Component extension with manifest resource id "
              << manifest_resource_id << " not in whitelist and is not being "
              << "loaded as a result.";
   NOTREACHED();
   return false;
 }
 
 }  // namespace extensions