Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2805133002: Fixed spelling mistakes in HttpRequest documentation. (Closed)

Created:
3 years, 8 months ago by bkonyi
Modified:
3 years, 7 months ago
Reviewers:
zra, Alan Knight
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fixed spelling mistakes in HttpRequest documentation. BUG= R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/c8e1e2aad74b33735493636956837eaf1d048199

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
bkonyi
3 years, 8 months ago (2017-04-06 22:05:51 UTC) #2
zra
lgtm
3 years, 8 months ago (2017-04-06 22:09:09 UTC) #3
bkonyi
Committed patchset #1 (id:1) manually as c8e1e2aad74b33735493636956837eaf1d048199 (presubmit successful).
3 years, 8 months ago (2017-04-13 18:49:41 UTC) #5
Alan Knight
Note that this doesn't actually work. dart:html is generated, and the next time it's regenerated ...
3 years, 7 months ago (2017-05-05 17:00:54 UTC) #7
zra
3 years, 7 months ago (2017-05-05 17:05:26 UTC) #8
Message was sent while issue was closed.
On 2017/05/05 17:00:54, Alan Knight wrote:
> Note that this doesn't actually work. dart:html is generated, and the next
time
> it's regenerated this change disappears. You need to modify docs.json. See
e.g.
> https://codereview.chromium.org/2832353003/ where this is being done again.

This message:

"// DO NOT EDIT - unless you are editing documentation as per:"

could be somewhat more clear. It makes it sound like editing documentation there
is fine.

Also the files should be marked read-only in the checkout.

Powered by Google App Engine
This is Rietveld 408576698