[Extensions Bindings] Allow schema violations through sendRequest

extensions/renderer/resources/context_menus_handlers.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Implementation of custom bindings for the contextMenus API.
 // This is used to implement the contextMenus API for extensions and for the
 // <webview> tag (see chrome_web_view_experimental.js).
 
 var contextMenuNatives = requireNative('context_menus');
-var sendRequest = require('sendRequest').sendRequest;
-var Event = require('event_bindings').Event;
-var lastError = require('lastError');
+var sendRequest = bindingUtil ?
+    $Function.bind(bindingUtil.sendRequest, bindingUtil) :
+    require('sendRequest').sendRequest;
+var hasLastError = bindingUtil ?
+    $Function(bindingUtil.hasLastError, bindingUtil) :

[lazyboy, 2017/04/07 20:31:34]

$Function.bind?

[Devlin, 2017/04/10 17:05:38]

Done.

+    require('lastError').hasError;
+
+var jsEvent;
+function createNewEvent(name) {
+  if (bindingUtil) {
+    // Native custom events ignore schema.
+    return bindingUtil.createCustomEvent(name, undefined, undefined);
+  }
+  if (!jsEvent)
+    jsEvent = require('event_bindings').Event;
+  return new jsEvent(name);
+}
 
 // Add the bindings to the contextMenus API.
 function createContextMenusHandlers(isWebview) {
   var eventName = isWebview ? 'webViewInternal.contextMenus' : 'contextMenus';
   // Some dummy value for chrome.contextMenus instances.
   // Webviews use positive integers, and 0 to denote an invalid webview ID.
   // The following constant is -1 to avoid any conflicts between webview IDs and
   // extensions.
   var INSTANCEID_NON_WEBVIEW = -1;
 
   // Generates a customCallback for a given method. |handleCallback| will be
   // invoked with the same arguments this function is called with.
   function getCallback(handleCallback) {
     return function() {
       var extensionCallback = arguments[arguments.length - 1];
-      if (lastError.hasError(chrome)) {
+      if (hasLastError(bindingUtil ? undefined : chrome)) {
         if (extensionCallback)
           extensionCallback();
         return;
       }
 
       $Function.apply(handleCallback, null, arguments);
       if (extensionCallback)
         extensionCallback();
     };
   }
 
   var contextMenus = { __proto__: null };
   contextMenus.handlers = { __proto__: null };
-  contextMenus.event = new Event(eventName);
+  contextMenus.event = createNewEvent(eventName);
 
   contextMenus.getIdFromCreateProperties = function(createProperties) {
     if (typeof createProperties.id !== 'undefined')
       return createProperties.id;
     return createProperties.generatedId;
   };
 
   contextMenus.handlersForId = function(instanceId, id) {
     if (!contextMenus.handlers[instanceId]) {
       contextMenus.handlers[instanceId] = {
@@ skipping 42 matching lines @@
     createProperties.generatedId = contextMenuNatives.GetNextContextMenuId();
     var id = contextMenus.getIdFromCreateProperties(createProperties);
     var instanceId = isWebview ? arguments[0] : INSTANCEID_NON_WEBVIEW;
     var onclick = createProperties.onclick;
 
     var optArgs = {
       __proto__: null,
       customCallback: getCallback($Function.bind(createCallback, null,
                                                  instanceId, id, onclick)),
     };
-    sendRequest(this.name, $Array.from(arguments),
-                this.definition.parameters, optArgs);
+    var name = isWebview ?
+        'chromeWebViewInternal.contextMenusCreate' : 'contextMenus.create';
+    sendRequest(name, $Array.from(arguments),
+                bindingUtil ? undefined : this.definition.parameters,
+                optArgs);
     return id;
   };
 
   function removeCallback(instanceId, id) {
     delete contextMenus.handlersForId(instanceId, id)[id];
   }
 
   requestHandlers.remove = function() {
     var instanceId = isWebview ? arguments[0] : INSTANCEID_NON_WEBVIEW;
     var id = isWebview ? arguments[1] : arguments[0];
     var optArgs = {
       __proto__: null,
       customCallback: getCallback($Function.bind(removeCallback, null,
                                                  instanceId, id)),
     };
-    sendRequest(this.name, $Array.from(arguments),
-                this.definition.parameters, optArgs);
+    var name = isWebview ?
+        'chromeWebViewInternal.contextMenusRemove' : 'contextMenus.remove';
+    sendRequest(name, $Array.from(arguments),
+                bindingUtil ? undefined : this.definition.parameters,
+                optArgs);
   };
 
   function updateCallback(instanceId, id, onclick) {
     if (onclick) {
       contextMenus.ensureListenerSetup();
       contextMenus.handlersForId(instanceId, id)[id] = onclick;
     } else if (onclick === null) {
       // When onclick is explicitly set to null, remove the event listener.
       delete contextMenus.handlersForId(instanceId, id)[id];
     }
   }
 
   requestHandlers.update = function() {
     var instanceId = isWebview ? arguments[0] : INSTANCEID_NON_WEBVIEW;
     var id = isWebview ? arguments[1] : arguments[0];
     var updateProperties = isWebview ? arguments[2] : arguments[1];
     var onclick = updateProperties.onclick;
     var optArgs = {
       __proto__: null,
       customCallback: getCallback($Function.bind(updateCallback, null,
                                                  instanceId, id, onclick)),
     };
 
-    sendRequest(this.name, $Array.from(arguments),
-                this.definition.parameters, optArgs);
+    var name = isWebview ?
+        'chromeWebViewInternal.contextMenusUpdate' :
+        'contextMenus.update';
+    sendRequest(name, $Array.from(arguments),
+                bindingUtil ? undefined : this.definition.parameters, optArgs);
   };
 
   function removeAllCallback(instanceId) {
     delete contextMenus.handlers[instanceId];
   }
 
   requestHandlers.removeAll = function() {
     var instanceId = isWebview ? arguments[0] : INSTANCEID_NON_WEBVIEW;
     var optArgs = {
       __proto__: null,
       customCallback: getCallback($Function.bind(removeAllCallback, null,
                                                  instanceId)),
     };
 
-    sendRequest(this.name, $Array.from(arguments),
+    var name = isWebview ?
+        'chromeWebViewInternal.contextMenusRemoveAll' :
+        'contextMenus.removeAll';
+    sendRequest(name, $Array.from(arguments),
                 this.definition.parameters, optArgs);
   };
 
   return {
     requestHandlers: requestHandlers,
   };
 }
 
 exports.$set('create', createContextMenusHandlers);