[Extensions Bindings] Allow schema violations through sendRequest

extensions/renderer/argument_spec.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/renderer/argument_spec.h"
 
 #include "base/memory/ptr_util.h"
 #include "base/values.h"
 #include "content/public/child/v8_value_converter.h"
 #include "extensions/renderer/api_type_reference_map.h"
@@ skipping 126 matching lines @@
 }
 
 ArgumentSpec::~ArgumentSpec() {}
 
 bool ArgumentSpec::ParseArgument(v8::Local<v8::Context> context,
                                  v8::Local<v8::Value> value,
                                  const APITypeReferenceMap& refs,
                                  std::unique_ptr<base::Value>* out_value,
                                  std::string* error) const {
   if (type_ == ArgumentType::FUNCTION) {
-    // We can't serialize functions. We shouldn't be asked to.
-    DCHECK(!out_value);
-    return value->IsFunction();
+    if (!value->IsFunction())
+      return false;
+
+    if (out_value) {
+      // Certain APIs (contextMenus) have functions as parameters other than the
+      // callback (contextMenus uses it for an onclick listener). Our generated
+      // types have adapted to consider functions "objects" and serialize them
+      // as dictionaries.
+      // TODO(devlin): It'd be awfully nice to get rid of this eccentricity.
+      *out_value = base::MakeUnique<base::DictionaryValue>();
+    }
+    return true;
   }
 
   if (type_ == ArgumentType::REF) {
     DCHECK(ref_);
     const ArgumentSpec* reference = refs.GetSpec(ref_.value());
     DCHECK(reference) << ref_.value();
     return reference->ParseArgument(context, value, refs, out_value, error);
   }
 
   if (type_ == ArgumentType::CHOICES) {
@@ skipping 270 matching lines @@
       return false;
     }
     if (type_ == ArgumentType::BINARY)
       DCHECK_EQ(base::Value::Type::BINARY, converted->GetType());
     *out_value = std::move(converted);
   }
   return true;
 }
 
 }  // namespace extensions