Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1009)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.cpp

Issue 2805103003: Optimize collapsed border calculation (step 2) (Closed)
Patch Set: - Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.cpp b/third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.cpp
index f48eca2513c8176d9edf4e1affcb0fc5e4ab3df6..bf598f0b26b2f1c3fe4c391fb6d7190045a47d34 100644
--- a/third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.cpp
@@ -10,17 +10,16 @@
namespace blink {
-void LayoutTableBoxComponent::InvalidateCollapsedBordersOnStyleChange(
+bool LayoutTableBoxComponent::NeedsInvalidateCollapsedBordersOnStyleChange(
const LayoutObject& table_part,
- LayoutTable& table,
+ const LayoutTable& table,
const StyleDifference& diff,
const ComputedStyle& old_style) {
if (!table.CollapseBorders())
- return;
- if (old_style.Border() != table_part.StyleRef().Border() ||
- (diff.TextDecorationOrColorChanged() &&
- table_part.StyleRef().HasBorderColorReferencingCurrentColor()))
- table.InvalidateCollapsedBorders();
+ return false;
+ return old_style.Border() != table_part.StyleRef().Border() ||
+ (diff.TextDecorationOrColorChanged() &&
+ table_part.StyleRef().HasBorderColorReferencingCurrentColor());
}
bool LayoutTableBoxComponent::DoCellsHaveDirtyWidth(

Powered by Google App Engine
This is Rietveld 408576698