Optimize collapsed border calculation (step 2)

third_party/WebKit/Source/core/layout/LayoutTableRow.cpp

 /*
  * Copyright (C) 1997 Martin Jones (mjones@kde.org)
  *           (C) 1997 Torben Weis (weis@kde.org)
  *           (C) 1998 Waldo Bastian (bastian@kde.org)
  *           (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2013
 *                Apple Inc.
  *               All rights reserved.
  *
@@ skipping 53 matching lines @@
 
   if (Section() && Style()->LogicalHeight() != old_style->LogicalHeight())
     Section()->RowLogicalHeightChanged(this);
 
   if (!Parent())
     return;
   LayoutTable* table = this->Table();
   if (!table)
     return;
 
-  LayoutTableBoxComponent::InvalidateCollapsedBordersOnStyleChange(
-      *this, *table, diff, *old_style);
+  if (LayoutTableBoxComponent::NeedsInvalidateCollapsedBordersOnStyleChange(
+          *this, *table, diff, *old_style))
+    InvalidateCollapsedBordersOfAffectedCells();
 
   if (LayoutTableBoxComponent::DoCellsHaveDirtyWidth(*this, *table, diff,
                                                      *old_style)) {
+    // TODO(wangxianzhu,dgrogan): The following seems incorrect the row's border
+    // is used by cells not in this row. Could reuse some code in
+    // InvalidateCollapsedBordersOfAffectedCells().
     // If the border width changes on a row, we need to make sure the cells in
     // the row know to lay out again.
     // This only happens when borders are collapsed, since they end up affecting
     // the border sides of the cell itself.
     for (LayoutBox* child_box = FirstChildBox(); child_box;
          child_box = child_box->NextSiblingBox()) {
       if (!child_box->IsTableCell())
         continue;
       // TODO(dgrogan) Add a layout test showing that setChildNeedsLayout is
       // needed instead of setNeedsLayout.
@@ skipping 70 matching lines @@
   if (before_child && before_child->Parent() != this)
     before_child = SplitAnonymousBoxesAroundChild(before_child);
 
   LayoutTableCell* cell = ToLayoutTableCell(child);
 
   DCHECK(!before_child || before_child->IsTableCell());
   LayoutTableBoxComponent::AddChild(cell, before_child);
 
   // Generated content can result in us having a null section so make sure to
   // null check our parent.
-  if (Parent()) {
-    Section()->AddCell(cell, this);
-    // When borders collapse, adding a cell can affect the the width of
-    // neighboring cells.
-    LayoutTable* enclosing_table = Table();
-    if (enclosing_table && enclosing_table->CollapseBorders()) {
-      enclosing_table->InvalidateCollapsedBorders();
-      if (LayoutTableCell* previous_cell = cell->PreviousCell())
-        previous_cell->SetNeedsLayoutAndPrefWidthsRecalc(
-            LayoutInvalidationReason::kTableChanged);
-      if (LayoutTableCell* next_cell = cell->NextCell())
-        next_cell->SetNeedsLayoutAndPrefWidthsRecalc(
-            LayoutInvalidationReason::kTableChanged);
-    }
-  }
+  if (!Parent())
+    return;
+
+  Section()->AddCell(cell, this);
 
   if (before_child || NextRow())
     Section()->SetNeedsCellRecalc();
+
+  // When borders collapse, adding a cell can affect the the width of
+  // neighboring cells.
+  LayoutTable* enclosing_table = Table();
+  if (enclosing_table && enclosing_table->CollapseBorders()) {
+    cell->InvalidateCollapsedBordersOfAffectedCells();
+    // TODO(wangxianzhu,dgrogan): The following seems incorrect if the cell has
+    // adjacent cells other than PreviousCell() and NextCell(). Could reuse some
+    // code in LayoutTableCell::InvalidateCollapsedBordersOfAffectedCells().
+    if (LayoutTableCell* previous_cell = cell->PreviousCell()) {
+      previous_cell->SetNeedsLayoutAndPrefWidthsRecalc(
+          LayoutInvalidationReason::kTableChanged);
+    }
+    if (LayoutTableCell* next_cell = cell->NextCell()) {
+      next_cell->SetNeedsLayoutAndPrefWidthsRecalc(
+          LayoutInvalidationReason::kTableChanged);
+    }
+  }
 }
 
 void LayoutTableRow::UpdateLayout() {
   DCHECK(NeedsLayout());
   LayoutAnalyzer::Scope analyzer(*this);
   bool paginated = View()->GetLayoutState()->IsPaginated();
 
   for (LayoutTableCell* cell = FirstCell(); cell; cell = cell->NextCell()) {
     SubtreeLayoutScope layouter(*cell);
     cell->SetLogicalTop(LogicalTop());
@@ skipping 129 matching lines @@
   // it wants us to drop headers on only the pages that a single row
   // won't fit but we avoid the complexity of that reading until it
   // is clarified. Tracked by crbug.com/675904
   if (RowIndex())
     return false;
   LayoutTableSection* header = Table()->Header();
   return header && Table()->SectionAbove(Section()) == header &&
          header->GetPaginationBreakability() != kAllowAnyBreaks;
 }
 
+void LayoutTableRow::InvalidateCollapsedBordersOfAffectedCells() {
+  auto* table = Table();
+  DCHECK(table->CollapseBorders());
+  if (table->NeedsInvalidateCollapsedBordersForAllCells())
+    return;
+
+  table->RecalcSectionsIfNeeded();
+  table->InvalidateCollapsedBorders();
+
+  // Invalidate cells intersecting this row.
+  auto* section = Section();
+  section->InvalidateCellCollapsedBordersIntersectingRow(RowIndex());
+
+  // Invalidate cells above this row.
+  if (RowIndex()) {
+    section->InvalidateCellCollapsedBordersIntersectingRow(RowIndex() - 1);
+  } else if (auto* section_above =
+                 table->SectionAbove(section, kSkipEmptySections)) {
+    section_above->InvalidateCellCollapsedBordersIntersectingRow(
+        section_above->NumRows() - 1);
+  }
+
+  // Invalidate cells below this row.
+  if (RowIndex() + 1 < section->NumRows()) {
+    section->InvalidateCellCollapsedBordersIntersectingRow(RowIndex() + 1);
+  } else if (auto* section_below =
+                 table->SectionBelow(section, kSkipEmptySections)) {
+    section_below->InvalidateCellCollapsedBordersIntersectingRow(0);
+  }
+}
+
 }  // namespace blink