Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3177)

Unified Diff: chrome/browser/dom_ui/new_tab_ui_uitest.cc

Issue 2805089: Add bookmark promo to NTP on first run. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/dom_ui/new_tab_ui.cc ('k') | chrome/browser/dom_ui/tips_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/dom_ui/new_tab_ui_uitest.cc
===================================================================
--- chrome/browser/dom_ui/new_tab_ui_uitest.cc (revision 52977)
+++ chrome/browser/dom_ui/new_tab_ui_uitest.cc (working copy)
@@ -161,6 +161,42 @@
bool is_home_page;
ASSERT_TRUE(browser->GetBooleanPreference(prefs::kHomePageIsNewTabPage,
- &is_home_page));
+ &is_home_page));
ASSERT_TRUE(is_home_page);
}
+
+TEST_F(NewTabUITest, PromoLink) {
+#if defined(OS_WIN)
+ scoped_refptr<BrowserProxy> browser(automation()->GetBrowserWindow(0));
+ ASSERT_TRUE(browser.get());
+
+ // Bring up a new tab page.
+ ASSERT_TRUE(browser->RunCommand(IDC_NEW_TAB));
+ int load_time;
+ ASSERT_TRUE(automation()->WaitForInitialNewTabUILoad(&load_time));
+
+ scoped_refptr<TabProxy> tab = browser->GetActiveTab();
+ ASSERT_TRUE(tab.get());
+
+ // Test "import bookmarks" promo.
+ bool result;
+ ASSERT_TRUE(tab->ExecuteAndExtractBool(L"",
+ L"window.domAutomationController.send("
+ L"(function() {"
+ L" tipCache = [{\"set_promo_tip\":"
+ L"\"<button class='link'>Import</button> bookmarks\"}];"
+ L" renderTip();"
+ L" var e = document.createEvent('Event');"
+ L" e.initEvent('click', true, true);"
+ L" var el = document.querySelector('#tip-line button');"
+ L" el.dispatchEvent(e);"
+ L" return true;"
+ L"})()"
+ L")",
+ &result));
+
+ ASSERT_TRUE(result);
+#endif
+ // TODO(mirandac): Ensure that we showed the import bookmarks dialog.
+ // Remove check for OS_WIN after implemented in Mac and Linux.
+}
« no previous file with comments | « chrome/browser/dom_ui/new_tab_ui.cc ('k') | chrome/browser/dom_ui/tips_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698