[Mac] Use Core Graphics to draw the close button used within tabs, infobars, ...

[Mac] Use Core Graphics to draw the close button used within tabs, infobars, the download shelf and other places. Delete the original pdfs. This is in line with the new top chrome refresh.

BUG=44574
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51367

[pink, 2010-06-30 18:49:33]

lgtm with comments addressed

http://codereview.chromium.org/2805055/diff/3001/2006
File chrome/browser/cocoa/hover_close_button.mm (right):

http://codereview.chromium.org/2805055/diff/3001/2006#newcode38
chrome/browser/cocoa/hover_close_button.mm:38: - (void)drawRect:(NSRect)rect {
Can you add some comments to denote what each large section of code does? Having
looked at a bunch of these over the last couple of weeks, having to re-divine
what each grouping does as a piece of the whole is painful with no comments.

http://codereview.chromium.org/2805055/diff/3001/2006#newcode48
chrome/browser/cocoa/hover_close_button.mm:48: endAngle:365];
make both of these floats? ie, 365.0?

http://codereview.chromium.org/2805055/diff/3001/2007
File chrome/browser/cocoa/third_party/LICENSE (right):

http://codereview.chromium.org/2805055/diff/3001/2007#newcode1
chrome/browser/cocoa/third_party/LICENSE:1: Copyright 2008 MolokoCacao
do we share a LICENSE file for all things in a directory?

http://codereview.chromium.org/2805055/diff/3001/2010
File chrome/browser/cocoa/third_party/README.chromium (right):

http://codereview.chromium.org/2805055/diff/3001/2010#newcode14
chrome/browser/cocoa/third_party/README.chromium:14: - Changed style to match
Chromium's.
really? i saw tons of style issues that i just ignored because it was 3rd party
code.

[Andrew Bonventre (Bons), 2010-06-30 19:34:27]

Moved the paths to be stored within their own instance vars.

http://codereview.chromium.org/2805055/diff/3001/2006
File chrome/browser/cocoa/hover_close_button.mm (right):

http://codereview.chromium.org/2805055/diff/3001/2006#newcode38
chrome/browser/cocoa/hover_close_button.mm:38: - (void)drawRect:(NSRect)rect {
On 2010/06/30 18:49:33, pink wrote:
> Can you add some comments to denote what each large section of code does?
Having
> looked at a bunch of these over the last couple of weeks, having to re-divine
> what each grouping does as a piece of the whole is painful with no comments.

Done.

http://codereview.chromium.org/2805055/diff/3001/2006#newcode48
chrome/browser/cocoa/hover_close_button.mm:48: endAngle:365];
On 2010/06/30 18:49:33, pink wrote:
> make both of these floats? ie, 365.0?

Done.

http://codereview.chromium.org/2805055/diff/3001/2007
File chrome/browser/cocoa/third_party/LICENSE (right):

http://codereview.chromium.org/2805055/diff/3001/2007#newcode1
chrome/browser/cocoa/third_party/LICENSE:1: Copyright 2008 MolokoCacao
On 2010/06/30 18:49:33, pink wrote:
> do we share a LICENSE file for all things in a directory?
According to mento, yes.

http://codereview.chromium.org/2805055/diff/3001/2010
File chrome/browser/cocoa/third_party/README.chromium (right):

http://codereview.chromium.org/2805055/diff/3001/2010#newcode14
chrome/browser/cocoa/third_party/README.chromium:14: - Changed style to match
Chromium's.
On 2010/06/30 18:49:33, pink wrote:
> really? i saw tons of style issues that i just ignored because it was 3rd
party
> code.

Done.

[Nico, 2010-07-01 16:19:25]

As far as I know, having local third_party directories makes evan sad. Please
move this to the global src/third_party directory.

[Evan Martin, 2010-07-01 16:44:01]

Yeah, Nico is right.

http://codereview.chromium.org/2805055/diff/9001/10009
File chrome/browser/cocoa/third_party/README.chromium (right):

http://codereview.chromium.org/2805055/diff/9001/10009#newcode6
chrome/browser/cocoa/third_party/README.chromium:6: License File: LICENSE
This isn't needed, for what it's worth (LICENSE is the implicit name)

[Andrew Bonventre (Bons), 2010-07-01 17:12:41]

My bad. Will move today.

A

On Thu, Jul 1, 2010 at 12:44 PM,  <evan@chromium.org> wrote:
> Yeah, Nico is right.
>
>
> http://codereview.chromium.org/2805055/diff/9001/10009
> File chrome/browser/cocoa/third_party/README.chromium (right):
>
> http://codereview.chromium.org/2805055/diff/9001/10009#newcode6
> chrome/browser/cocoa/third_party/README.chromium:6: License File:
> LICENSE
> This isn't needed, for what it's worth (LICENSE is the implicit name)
>
> http://codereview.chromium.org/2805055/show
>