Chromium Code Reviews
Help | Chromium Project | Sign in
(20)

Issue 2805055: [Mac] Use Core Graphics to draw the close button used within tabs, infobars, ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 11 months ago by Andrew Bonventre (Bons)
Modified:
3 years, 10 months ago
Reviewers:
pink, Nico, Evan Martin
CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

[Mac] Use Core Graphics to draw the close button used within tabs, infobars, the download shelf and other places. Delete the original pdfs. This is in line with the new top chrome refresh. BUG=44574 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51367

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 8

Patch Set 3 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+401 lines, -33 lines) Patch
D chrome/app/theme/close_bar.pdf View Binary file 0 comments Download
D chrome/app/theme/close_bar_h.pdf View Binary file 0 comments Download
D chrome/app/theme/close_bar_p.pdf View Binary file 0 comments Download
M chrome/browser/cocoa/hover_close_button.h View 1 2 2 chunks +24 lines, -8 lines 0 comments Download
M chrome/browser/cocoa/hover_close_button.mm View 1 2 4 chunks +89 lines, -22 lines 0 comments Download
A chrome/browser/cocoa/third_party/LICENSE View 1 chunk +23 lines, -0 lines 0 comments Download
A chrome/browser/cocoa/third_party/NSBezierPath+MCAdditions.h View 1 chunk +24 lines, -0 lines 0 comments Download
A chrome/browser/cocoa/third_party/NSBezierPath+MCAdditions.m View 1 chunk +225 lines, -0 lines 0 comments Download
A chrome/browser/cocoa/third_party/README.chromium View 2 1 chunk +14 lines, -0 lines 1 comment Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_dll.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
Commit: CQ not working?

Messages

Total messages: 6 (0 generated)
pink
4 years, 11 months ago (2010-06-30 17:52:07 UTC) #1
pink
lgtm with comments addressed http://codereview.chromium.org/2805055/diff/3001/2006 File chrome/browser/cocoa/hover_close_button.mm (right): http://codereview.chromium.org/2805055/diff/3001/2006#newcode38 chrome/browser/cocoa/hover_close_button.mm:38: - (void)drawRect:(NSRect)rect { Can you ...
4 years, 11 months ago (2010-06-30 18:49:33 UTC) #2
Andrew Bonventre (Bons)
Moved the paths to be stored within their own instance vars. http://codereview.chromium.org/2805055/diff/3001/2006 File chrome/browser/cocoa/hover_close_button.mm (right): ...
4 years, 11 months ago (2010-06-30 19:34:27 UTC) #3
Nico
As far as I know, having local third_party directories makes evan sad. Please move this ...
4 years, 11 months ago (2010-07-01 16:19:25 UTC) #4
Evan Martin
Yeah, Nico is right. http://codereview.chromium.org/2805055/diff/9001/10009 File chrome/browser/cocoa/third_party/README.chromium (right): http://codereview.chromium.org/2805055/diff/9001/10009#newcode6 chrome/browser/cocoa/third_party/README.chromium:6: License File: LICENSE This isn't ...
4 years, 11 months ago (2010-07-01 16:44:01 UTC) #5
Andrew Bonventre (Bons)
4 years, 11 months ago (2010-07-01 17:12:41 UTC) #6
My bad. Will move today.

A

On Thu, Jul 1, 2010 at 12:44 PM,  <evan@chromium.org> wrote:
> Yeah, Nico is right.
>
>
> http://codereview.chromium.org/2805055/diff/9001/10009
> File chrome/browser/cocoa/third_party/README.chromium (right):
>
> http://codereview.chromium.org/2805055/diff/9001/10009#newcode6
> chrome/browser/cocoa/third_party/README.chromium:6: License File:
> LICENSE
> This isn't needed, for what it's worth (LICENSE is the implicit name)
>
> http://codereview.chromium.org/2805055/show
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be