Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Side by Side Diff: components/cronet/android/api/src/org/chromium/net/ICronetEngineBuilder.java

Issue 2805053005: [Cronet] Enable Brotli (Closed)
Patch Set: add test Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 package org.chromium.net; 4 package org.chromium.net;
5 5
6 import java.util.Date; 6 import java.util.Date;
7 import java.util.Set; 7 import java.util.Set;
8 8
9 /** 9 /**
10 * Defines methods that the actual implementation of {@link CronetEngine.Builder } has to implement. 10 * Defines methods that the actual implementation of {@link CronetEngine.Builder } has to implement.
11 * {@code CronetEngine.Builder} uses this interface to delegate the calls. 11 * {@code CronetEngine.Builder} uses this interface to delegate the calls.
12 * For the documentation of individual methods, please see the identically named methods in 12 * For the documentation of individual methods, please see the identically named methods in
13 * {@link org.chromium.net.CronetEngine.Builder} and 13 * {@link org.chromium.net.CronetEngine.Builder} and
14 * {@link org.chromium.net.ExperimentalCronetEngine.Builder}. 14 * {@link org.chromium.net.ExperimentalCronetEngine.Builder}.
15 * 15 *
16 * {@hide internal class} 16 * {@hide internal class}
17 */ 17 */
18 public abstract class ICronetEngineBuilder { 18 public abstract class ICronetEngineBuilder {
19 // Public API methods. 19 // Public API methods.
20 public abstract ICronetEngineBuilder addPublicKeyPins(String hostName, Set<b yte[]> pinsSha256, 20 public abstract ICronetEngineBuilder addPublicKeyPins(String hostName, Set<b yte[]> pinsSha256,
21 boolean includeSubdomains, Date expirationDate); 21 boolean includeSubdomains, Date expirationDate);
22 public abstract ICronetEngineBuilder addQuicHint(String host, int port, int alternatePort); 22 public abstract ICronetEngineBuilder addQuicHint(String host, int port, int alternatePort);
23 public abstract ICronetEngineBuilder enableDataReductionProxy(String key); 23 public abstract ICronetEngineBuilder enableDataReductionProxy(String key);
24 public abstract ICronetEngineBuilder enableHttp2(boolean value); 24 public abstract ICronetEngineBuilder enableHttp2(boolean value);
25 public abstract ICronetEngineBuilder enableHttpCache(int cacheMode, long max Size); 25 public abstract ICronetEngineBuilder enableHttpCache(int cacheMode, long max Size);
26 public abstract ICronetEngineBuilder enablePublicKeyPinningBypassForLocalTru stAnchors( 26 public abstract ICronetEngineBuilder enablePublicKeyPinningBypassForLocalTru stAnchors(
27 boolean value); 27 boolean value);
28 public abstract ICronetEngineBuilder enableQuic(boolean value); 28 public abstract ICronetEngineBuilder enableQuic(boolean value);
29 public abstract ICronetEngineBuilder enableSdch(boolean value); 29 public abstract ICronetEngineBuilder enableSdch(boolean value);
30 public abstract ICronetEngineBuilder enableBrotli(boolean value);
mef 2017/04/12 17:45:49 This method should have default 'do nothing' imple
xunjieli 2017/04/13 21:26:14 Done.
30 public abstract ICronetEngineBuilder setExperimentalOptions(String options); 31 public abstract ICronetEngineBuilder setExperimentalOptions(String options);
31 public abstract ICronetEngineBuilder setLibraryLoader( 32 public abstract ICronetEngineBuilder setLibraryLoader(
32 CronetEngine.Builder.LibraryLoader loader); 33 CronetEngine.Builder.LibraryLoader loader);
33 public abstract ICronetEngineBuilder setStoragePath(String value); 34 public abstract ICronetEngineBuilder setStoragePath(String value);
34 public abstract ICronetEngineBuilder setUserAgent(String userAgent); 35 public abstract ICronetEngineBuilder setUserAgent(String userAgent);
35 public abstract String getDefaultUserAgent(); 36 public abstract String getDefaultUserAgent();
36 public abstract ExperimentalCronetEngine build(); 37 public abstract ExperimentalCronetEngine build();
37 38
38 // Experimental API methods. 39 // Experimental API methods.
39 // 40 //
40 // Note: all experimental API methods should have default implementation. Th is will allow 41 // Note: all experimental API methods should have default implementation. Th is will allow
41 // removing the experimental methods from the implementation layer without b reaking 42 // removing the experimental methods from the implementation layer without b reaking
42 // the client. 43 // the client.
43 44
44 public ICronetEngineBuilder enableNetworkQualityEstimator(boolean value) { 45 public ICronetEngineBuilder enableNetworkQualityEstimator(boolean value) {
45 return this; 46 return this;
46 } 47 }
47 48
48 public ICronetEngineBuilder setCertVerifierData(String certVerifierData) { 49 public ICronetEngineBuilder setCertVerifierData(String certVerifierData) {
49 return this; 50 return this;
50 } 51 }
51 52
52 public ICronetEngineBuilder setDataReductionProxyOptions( 53 public ICronetEngineBuilder setDataReductionProxyOptions(
53 String primaryProxy, String fallbackProxy, String secureProxyCheckUr l) { 54 String primaryProxy, String fallbackProxy, String secureProxyCheckUr l) {
54 return this; 55 return this;
55 } 56 }
56 } 57 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698