[Cronet] Enable Brotli

components/cronet/android/test/javatests/src/org/chromium/net/BrotliTest.java

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.net;
+
+import android.support.test.filters.SmallTest;
+
+import org.chromium.base.test.util.Feature;
+
+/**
+ * Simple test for Brotli support.
+ */
+public class BrotliTest extends CronetTestBase {
+    private CronetTestFramework mTestFramework;
+
+    @Override
+    protected void setUp() throws Exception {
+        super.setUp();
+        // Load library first to create MockCertVerifier.
+        System.loadLibrary("cronet_tests");
+        assertTrue(Http2TestServer.startHttp2TestServer(
+                getContext(), QuicTestServer.getServerCert(), QuicTestServer.getServerCertKey()));
+    }
+
+    @Override
+    protected void tearDown() throws Exception {
+        assertTrue(Http2TestServer.shutdownHttp2TestServer());
+        mTestFramework.mCronetEngine.shutdown();
+        super.tearDown();
+    }
+
+    @SmallTest
+    @Feature({"Cronet"})
+    @OnlyRunNativeCronet
+    public void testBrotliAdvertised() throws Exception {
+        ExperimentalCronetEngine.Builder builder =
+                new ExperimentalCronetEngine.Builder(getContext());
+        builder.enableBrotli(true);
+        CronetTestUtil.setMockCertVerifierForTesting(
+                builder, QuicTestServer.createMockCertVerifier());
+        mTestFramework = startCronetTestFrameworkWithUrlAndCronetEngineBuilder(null, builder);
+        String url = Http2TestServer.getEchoAllHeadersUrl();
+        TestUrlRequestCallback callback = startAndWaitForComplete(url);
+        assertEquals(200, callback.mResponseInfo.getHttpStatusCode());
+        assertTrue(callback.mResponseAsString.contains("accept-encoding: gzip, deflate, br"));
+    }
+
+    @SmallTest
+    @Feature({"Cronet"})
+    @OnlyRunNativeCronet
+    public void testBrotliNotAdvertised() throws Exception {
+        ExperimentalCronetEngine.Builder builder =
+                new ExperimentalCronetEngine.Builder(getContext());
+        CronetTestUtil.setMockCertVerifierForTesting(
+                builder, QuicTestServer.createMockCertVerifier());
+        mTestFramework = startCronetTestFrameworkWithUrlAndCronetEngineBuilder(null, builder);
+        String url = Http2TestServer.getEchoAllHeadersUrl();
+        TestUrlRequestCallback callback = startAndWaitForComplete(url);
+        assertEquals(200, callback.mResponseInfo.getHttpStatusCode());
+        assertFalse(callback.mResponseAsString.contains("br"));
+    }
+
+    @SmallTest
+    @Feature({"Cronet"})
+    @OnlyRunNativeCronet
+    public void testBrotliDecoded() throws Exception {
+        ExperimentalCronetEngine.Builder builder =
+                new ExperimentalCronetEngine.Builder(getContext());
+        builder.enableBrotli(true);
+        CronetTestUtil.setMockCertVerifierForTesting(
+                builder, QuicTestServer.createMockCertVerifier());
+        mTestFramework = startCronetTestFrameworkWithUrlAndCronetEngineBuilder(null, builder);
+        String url = Http2TestServer.getServeSimpleBrotliResponse();
+        TestUrlRequestCallback callback = startAndWaitForComplete(url);
+        assertEquals(200, callback.mResponseInfo.getHttpStatusCode());
+        String expectedResponse = "The quick brown fox jumps over the lazy dog\0";

[mef, 2017/04/14 13:42:04]

I'm a bit curious about \0 here. 
Is it intentional to verify that 0 is not treated as string terminator?

[xunjieli, 2017/04/14 14:16:58]

It used to be a EndOfText charater (0x03). I replaced it with 0x00 because I am
not sure how to represent 0x03 in java string. 
I can get rid of the terminator all together? WDYT?

The 0x03 came from xxd -i this file:
https://github.com/google/brotli/blob/master/tests/testdata/quickfox.compressed.

[mef, 2017/04/14 17:02:07]

Thanks for explanation! 
Looking at uncompressed
https://raw.githubusercontent.com/google/brotli/master/tests/testdata/quickfox
there shouldn't be any weird character at the end of uncompressed string, so
this seems odd. 

+        assertEquals(expectedResponse, callback.mResponseAsString);
+        assertEquals(callback.mResponseInfo.getAllHeaders().get("content-encoding").get(0), "br");
+    }
+
+    private TestUrlRequestCallback startAndWaitForComplete(String url) {
+        TestUrlRequestCallback callback = new TestUrlRequestCallback();
+        UrlRequest.Builder builder = mTestFramework.mCronetEngine.newUrlRequestBuilder(
+                url, callback, callback.getExecutor());
+        builder.build().start();
+        callback.blockForDone();
+        return callback;
+    }
+}