Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp

Issue 2805043003: Requiring Get prefix for 5 more methods (to avoid conflicts after Blink rename). (Closed)
Patch Set: Rebasing... Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp
diff --git a/tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp b/tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp
index 54f3da7866b704cf1333eff2be0568123045df7f..832ee5ac90c6de294c00e1eec556b3311e6b936b 100644
--- a/tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp
+++ b/tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp
@@ -658,6 +658,7 @@ bool ShouldPrefixFunctionName(const std::string& old_method_name) {
// Functions that are named similarily to a type - they should be prefixed
// with a "Get" prefix.
static const char* kConflictingMethods[] = {
+ "accumulatorMap",
"animationWorklet",
"audioWorklet",
"binaryType",
@@ -673,6 +674,7 @@ bool ShouldPrefixFunctionName(const std::string& old_method_name) {
"emptySpellCheckerClient",
"entryType",
"error",
+ "eventTargetDataMap",
"fileUtilities",
"font",
"frame",
@@ -681,6 +683,7 @@ bool ShouldPrefixFunctionName(const std::string& old_method_name) {
"gridCell",
"hash",
"heapObjectHeader",
+ "heapObjectSet",
"iconURL",
"image",
"inputMethodController",
@@ -708,6 +711,7 @@ bool ShouldPrefixFunctionName(const std::string& old_method_name) {
"path",
"position",
"processingInstruction",
+ "qualifiedNameCache",
"readyState",
"relList",
"referrer",
@@ -721,6 +725,7 @@ bool ShouldPrefixFunctionName(const std::string& old_method_name) {
"scrollAnimator",
"selectionInDOMTree",
"selectionInFlatTree",
+ "selectorTextCache",
"settings",
"signalingState",
"snapshotById",
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698