Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Side by Side Diff: chrome/browser/resources/chromeos/login/login_shared.js

Issue 2805033002: Fix flaky NPE in oobe.js. (Closed)
Patch Set: address comments. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview Common OOBE controller methods. This method is shared between 6 * @fileoverview Common OOBE controller methods. This method is shared between
7 * OOBE, login, and the lock screen. Add only methods that need to be shared 7 * OOBE, login, and the lock screen. Add only methods that need to be shared
8 * between all *three* screens here, as each additional method increases the 8 * between all *three* screens here, as each additional method increases the
9 * time it takes to show the lock screen. 9 * time it takes to show the lock screen.
10 * 10 *
(...skipping 262 matching lines...) Expand 10 before | Expand all | Expand 10 after
273 }; 273 };
274 274
275 /** 275 /**
276 * Restores input focus to currently selected pod. 276 * Restores input focus to currently selected pod.
277 */ 277 */
278 Oobe.refocusCurrentPod = function() { 278 Oobe.refocusCurrentPod = function() {
279 DisplayManager.refocusCurrentPod(); 279 DisplayManager.refocusCurrentPod();
280 }; 280 };
281 281
282 /** 282 /**
283 * Some ForTesting APIs directly access to DOM. Because this script is loaded
284 * in header, DOM tree may not be available at beginning.
285 * In DOMContentLoaded, this is marked to true, indicating ForTesting methods
286 * can be called.
287 * External script using ForTesting APIs should wait for this condition.
288 * @type {boolean}
289 */
290 Oobe.readyForTesting = false;
291
292 /**
283 * Skip to login screen for telemetry. 293 * Skip to login screen for telemetry.
284 */ 294 */
285 Oobe.skipToLoginForTesting = function() { 295 Oobe.skipToLoginForTesting = function() {
286 Oobe.disableSigninUI(); 296 Oobe.disableSigninUI();
287 chrome.send('skipToLoginForTesting'); 297 chrome.send('skipToLoginForTesting');
288 }; 298 };
289 299
290 /** 300 /**
291 * Login for telemetry. 301 * Login for telemetry.
292 * @param {string} username Login username. 302 * @param {string} username Login username.
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
433 src instanceof HTMLInputElement && 443 src instanceof HTMLInputElement &&
434 /text|password|search/.test(src.type); 444 /text|password|search/.test(src.type);
435 }); 445 });
436 446
437 447
438 (function() { 448 (function() {
439 'use strict'; 449 'use strict';
440 450
441 document.addEventListener('DOMContentLoaded', function() { 451 document.addEventListener('DOMContentLoaded', function() {
442 Oobe.initialize(); 452 Oobe.initialize();
453 Oobe.readyForTesting = true;
443 }); 454 });
444 455
445 // Install a global error handler so stack traces are included in logs. 456 // Install a global error handler so stack traces are included in logs.
446 window.onerror = function(message, file, line, column, error) { 457 window.onerror = function(message, file, line, column, error) {
447 console.error(error.stack); 458 console.error(error.stack);
448 } 459 }
449 })(); 460 })();
450
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698