Fix flaky NPE in oobe.js.

chrome/browser/resources/chromeos/login/login_shared.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Common OOBE controller methods. This method is shared between
  * OOBE, login, and the lock screen. Add only methods that need to be shared
  * between all *three* screens here, as each additional method increases the
  * time it takes to show the lock screen.
  *
@@ skipping 34 matching lines @@
    */
   var HEADER_BAR_DELAY_MS = 300;
 
   cr.addSingletonGetter(Oobe);
 
   Oobe.prototype = {
     __proto__: DisplayManager.prototype,
   };
 
   /**
+   * Some ForTesting APIs directly access to DOM. Because this script is loaded
+   * in header, DOM tree may not be available at beginning.
+   * In DOMContentLoaded, this is marked to true, indicating ForTesting methods
+   * can be called.
+   * External script using ForTesting APIs should wait for this condition.
+   * @type {boolean}
+   */
+  Oobe.readyForTesting = false;
+
+  /**
    * Handle accelerators. These are passed from native code instead of a JS
    * event handler in order to make sure that embedded iframes cannot swallow
    * them.
    * @param {string} name Accelerator name.
    */
   Oobe.handleAccelerator = function(name) {
     Oobe.getInstance().handleAccelerator(name);
   };
 
   /**
@@ skipping 210 matching lines @@
   /**
    * Restores input focus to currently selected pod.
    */
   Oobe.refocusCurrentPod = function() {
     DisplayManager.refocusCurrentPod();
   };
 
   /**
    * Skip to login screen for telemetry.
    */
   Oobe.skipToLoginForTesting = function() {

[achuithb, 2017/04/07 08:56:02]

We have a number of testing methods here. Can you move this to down here?

[hidehiko, 2017/04/07 09:09:41]

Do you mean moving readyForTesting like PS2? Assuming so, done. If I'm wrong,
please fix me.

     Oobe.disableSigninUI();
     chrome.send('skipToLoginForTesting');
   };
 
   /**
    * Login for telemetry.
    * @param {string} username Login username.
    * @param {string} password Login password.
    * @param {boolean} enterpriseEnroll Login as an enterprise enrollment?
    */
@@ skipping 137 matching lines @@
          src instanceof HTMLInputElement &&
          /text|password|search/.test(src.type);
 });
 
 
 (function() {
   'use strict';
 
   document.addEventListener('DOMContentLoaded', function() {
     Oobe.initialize();
+    Oobe.readyForTesting = true;
   });
 
   // Install a global error handler so stack traces are included in logs.
   window.onerror = function(message, file, line, column, error) {
     console.error(error.stack);
   }
 })();
-