Issue 2805013: [Isolates] Fixing ARM build after merge.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2805013: [Isolates] Fixing ARM build after merge. (Closed)

Created:
10 years, 6 months ago by Dmitry Titov

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry, zarko

CC:
v8-dev

Base URL:
git@github.com:v8isolate/v8isolates.git

Visibility:
Public.

Description

Fixing ARM build after merge. Committed: http://code.google.com/p/v8/source/detail?r=4886

Patch Set 1 #

Total comments: 1

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -10 lines)			Patch
	M	src/arm/codegen-arm.cc	View		6 chunks	+8 lines, -7 lines	1 comment	Download
	M	src/arm/macro-assembler-arm.cc	View		3 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

10 years, 6 months ago (2010-06-17 07:00:15 UTC) #3

http://codereview.chromium.org/2805013/diff/1/2
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/2805013/diff/1/2#newcode5116
src/arm/codegen-arm.cc:5116: if
(Isolate::Current()->cpu_features()->IsSupported(VFP3)) {
If one isolate has VFP then they all have VFP, so this doesn't make a whole lot
of sense to me.

Expand Messages | Collapse Messages