Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2804993002: Extract ResolutionWorldBuilderBase from ElementResolutionWorldBuilder (Closed)

Created:
3 years, 8 months ago by Johnni Winther
Modified:
3 years, 8 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Extract ResolutionWorldBuilderBase from ElementResolutionWorldBuilder This is a step towards reusing parts of ElementResolutionWorldBuilder for kernel-based elements. R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/97b19651a57fa52c7284fded8bfc7b0767cb4e77

Patch Set 1 #

Patch Set 2 : Cleanup. #

Patch Set 3 : Cleanup. #

Patch Set 4 : Fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+409 lines, -330 lines) Patch
M pkg/compiler/lib/src/common_elements.dart View 1 chunk +5 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 1 2 3 1 chunk +6 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/elements/entities.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/mirrors_data.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/kernel/elements.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/kernel/world_builder.dart View 2 chunks +7 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 1 chunk +2 lines, -3 lines 0 comments Download
A pkg/compiler/lib/src/universe/element_world_builder.dart View 1 chunk +260 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/universe/resolution_world_builder.dart View 1 2 25 chunks +99 lines, -293 lines 0 comments Download
M pkg/compiler/lib/src/universe/world_builder.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/world.dart View 4 chunks +12 lines, -12 lines 0 comments Download
M tests/compiler/dart2js/check_elements_invariants_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/instantiated_classes_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/kernel/closed_world_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/serialization/model_test_helper.dart View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 8 months ago (2017-04-06 11:07:46 UTC) #2
Emily Fortuna
lgtm!
3 years, 8 months ago (2017-04-07 01:51:05 UTC) #3
Johnni Winther
3 years, 8 months ago (2017-04-07 08:00:01 UTC) #5
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
97b19651a57fa52c7284fded8bfc7b0767cb4e77 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698