third_party/WebKit/Source/core/frame/FrameView.cpp - Issue 2804983003: [blink] Use early returns in baseBackgroundColor(Override) setters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2804983003: [blink] Use early returns in baseBackgroundColor(Override) setters. (Closed)

Patch Set: Revert compositing update fix, keep other changes. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/FrameView.cpp

diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp

index b1d02ace0ffb01dbc2ba7b3a91873001b71fb05a..079018f8849411f6d559e9f87cc0d35a6fa0f70f 100644

--- a/third_party/WebKit/Source/core/frame/FrameView.cpp

+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp

@@ -2342,6 +2342,9 @@ Color FrameView::baseBackgroundColor() const {

}

void FrameView::setBaseBackgroundColor(const Color& backgroundColor) {

+ if (m_baseBackgroundColor == backgroundColor)

+ return;

m_baseBackgroundColor = backgroundColor;

if (!layoutViewItem().isNull() &&

« no previous file with comments | « no previous file | third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp » ('j') | no next file with comments »