chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastWebContentsActivity.java - Issue 2804953003: Refactor ContentViewClient (6/6)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastWebContentsActivity.java

Issue 2804953003: Refactor ContentViewClient (6/6) (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/OSKOverscrollTest.java ('k') | content/browser/android/content_view_core_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastWebContentsActivity.java

diff --git a/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastWebContentsActivity.java b/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastWebContentsActivity.java

index 0ce8a5ab9057d0efb56dec3c1916d5e49bebd87a..69caebf5f9d17bca9eb57ccf677990185e870e6d 100644

--- a/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastWebContentsActivity.java

+++ b/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastWebContentsActivity.java

@@ -27,7 +27,6 @@ import org.chromium.base.annotations.JNINamespace;

import org.chromium.content.browser.ActivityContentVideoViewEmbedder;

import org.chromium.content.browser.ContentVideoViewEmbedder;

import org.chromium.content.browser.ContentView;

-import org.chromium.content.browser.ContentViewClient;

import org.chromium.content.browser.ContentViewCore;

import org.chromium.content.browser.ContentViewRenderView;

import org.chromium.content_public.browser.WebContents;

@@ -53,7 +52,6 @@ public class CastWebContentsActivity extends Activity {

private IntentFilter mWindowDestroyedIntentFilter;

private FrameLayout mCastWebContentsLayout;

private AudioManager mAudioManager;

- private ContentViewClient mContentViewClient;

private ContentViewRenderView mContentViewRenderView;

private WindowAndroid mWindow;

private ContentViewCore mContentViewCore;

@@ -321,8 +319,6 @@ public class CastWebContentsActivity extends Activity {

mContentView = ContentView.createContentView(this, mContentViewCore);

mContentViewCore.initialize(ViewAndroidDelegate.createBasicDelegate(mContentView),

mContentView, webContents, mWindow);

- mContentViewClient = new ContentViewClient();

- mContentViewCore.setContentViewClient(mContentViewClient);

// Enable display of current webContents.

if (getParent() != null) mContentViewCore.onShow();

mCastWebContentsLayout.addView(