[WASM SIMD] Implement horizontal add for float and integer types.

src/compiler/machine-operator.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/machine-operator.h"
 
 #include "src/base/lazy-instance.h"
 #include "src/compiler/opcodes.h"
 #include "src/compiler/operator.h"
 
@@ skipping 215 matching lines @@
   V(Word32PairSar, Operator::kNoProperties, 3, 0, 2)                      \
   V(F32x4Splat, Operator::kNoProperties, 1, 0, 1)                         \
   V(F32x4SConvertI32x4, Operator::kNoProperties, 1, 0, 1)                 \
   V(F32x4UConvertI32x4, Operator::kNoProperties, 1, 0, 1)                 \
   V(F32x4Abs, Operator::kNoProperties, 1, 0, 1)                           \
   V(F32x4Neg, Operator::kNoProperties, 1, 0, 1)                           \
   V(F32x4Sqrt, Operator::kNoProperties, 1, 0, 1)                          \
   V(F32x4RecipApprox, Operator::kNoProperties, 1, 0, 1)                   \
   V(F32x4RecipSqrtApprox, Operator::kNoProperties, 1, 0, 1)               \
   V(F32x4Add, Operator::kCommutative, 2, 0, 1)                            \
+  V(F32x4AddHoriz, Operator::kCommutative, 2, 0, 1)                       \

[georgia.kouveli, 2017/04/20 14:53:06]

These nodes as implemented should not be marked commutative - if you try
changing the order of the operands in RunF32x4HorizOpTest, for example, the test
fails.

[bbudge, 2017/04/21 20:18:58]

Good catch, done.

   V(F32x4Sub, Operator::kNoProperties, 2, 0, 1)                           \
   V(F32x4Mul, Operator::kCommutative, 2, 0, 1)                            \
   V(F32x4Div, Operator::kNoProperties, 2, 0, 1)                           \
   V(F32x4Min, Operator::kCommutative, 2, 0, 1)                            \
   V(F32x4Max, Operator::kCommutative, 2, 0, 1)                            \
   V(F32x4MinNum, Operator::kCommutative, 2, 0, 1)                         \
   V(F32x4MaxNum, Operator::kCommutative, 2, 0, 1)                         \
   V(F32x4RecipRefine, Operator::kNoProperties, 2, 0, 1)                   \
   V(F32x4RecipSqrtRefine, Operator::kNoProperties, 2, 0, 1)               \
   V(F32x4Eq, Operator::kCommutative, 2, 0, 1)                             \
   V(F32x4Ne, Operator::kCommutative, 2, 0, 1)                             \
   V(F32x4Lt, Operator::kNoProperties, 2, 0, 1)                            \
   V(F32x4Le, Operator::kNoProperties, 2, 0, 1)                            \
   V(I32x4Splat, Operator::kNoProperties, 1, 0, 1)                         \
   V(I32x4SConvertF32x4, Operator::kNoProperties, 1, 0, 1)                 \
   V(I32x4SConvertI16x8Low, Operator::kNoProperties, 1, 0, 1)              \
   V(I32x4SConvertI16x8High, Operator::kNoProperties, 1, 0, 1)             \
   V(I32x4Neg, Operator::kNoProperties, 1, 0, 1)                           \
   V(I32x4Add, Operator::kCommutative, 2, 0, 1)                            \
+  V(I32x4AddHoriz, Operator::kCommutative, 2, 0, 1)                       \
   V(I32x4Sub, Operator::kNoProperties, 2, 0, 1)                           \
   V(I32x4Mul, Operator::kCommutative, 2, 0, 1)                            \
   V(I32x4MinS, Operator::kCommutative, 2, 0, 1)                           \
   V(I32x4MaxS, Operator::kCommutative, 2, 0, 1)                           \
   V(I32x4Eq, Operator::kCommutative, 2, 0, 1)                             \
   V(I32x4Ne, Operator::kCommutative, 2, 0, 1)                             \
   V(I32x4LtS, Operator::kNoProperties, 2, 0, 1)                           \
   V(I32x4LeS, Operator::kNoProperties, 2, 0, 1)                           \
   V(I32x4UConvertF32x4, Operator::kNoProperties, 1, 0, 1)                 \
   V(I32x4UConvertI16x8Low, Operator::kNoProperties, 1, 0, 1)              \
   V(I32x4UConvertI16x8High, Operator::kNoProperties, 1, 0, 1)             \
   V(I32x4MinU, Operator::kCommutative, 2, 0, 1)                           \
   V(I32x4MaxU, Operator::kCommutative, 2, 0, 1)                           \
   V(I32x4LtU, Operator::kNoProperties, 2, 0, 1)                           \
   V(I32x4LeU, Operator::kNoProperties, 2, 0, 1)                           \
   V(I16x8Splat, Operator::kNoProperties, 1, 0, 1)                         \
   V(I16x8SConvertI8x16Low, Operator::kNoProperties, 1, 0, 1)              \
   V(I16x8SConvertI8x16High, Operator::kNoProperties, 1, 0, 1)             \
   V(I16x8Neg, Operator::kNoProperties, 1, 0, 1)                           \
   V(I16x8SConvertI32x4, Operator::kNoProperties, 2, 0, 1)                 \
   V(I16x8Add, Operator::kCommutative, 2, 0, 1)                            \
   V(I16x8AddSaturateS, Operator::kCommutative, 2, 0, 1)                   \
+  V(I16x8AddHoriz, Operator::kCommutative, 2, 0, 1)                       \
   V(I16x8Sub, Operator::kNoProperties, 2, 0, 1)                           \
   V(I16x8SubSaturateS, Operator::kNoProperties, 2, 0, 1)                  \
   V(I16x8Mul, Operator::kCommutative, 2, 0, 1)                            \
   V(I16x8MinS, Operator::kCommutative, 2, 0, 1)                           \
   V(I16x8MaxS, Operator::kCommutative, 2, 0, 1)                           \
   V(I16x8Eq, Operator::kCommutative, 2, 0, 1)                             \
   V(I16x8Ne, Operator::kCommutative, 2, 0, 1)                             \
   V(I16x8LtS, Operator::kNoProperties, 2, 0, 1)                           \
   V(I16x8LeS, Operator::kNoProperties, 2, 0, 1)                           \
   V(I16x8UConvertI8x16Low, Operator::kNoProperties, 1, 0, 1)              \
   V(I16x8UConvertI8x16High, Operator::kNoProperties, 1, 0, 1)             \
   V(I16x8UConvertI32x4, Operator::kNoProperties, 2, 0, 1)                 \
   V(I16x8AddSaturateU, Operator::kCommutative, 2, 0, 1)                   \
   V(I16x8SubSaturateU, Operator::kNoProperties, 2, 0, 1)                  \
   V(I16x8MinU, Operator::kCommutative, 2, 0, 1)                           \
   V(I16x8MaxU, Operator::kCommutative, 2, 0, 1)                           \
   V(I16x8LtU, Operator::kNoProperties, 2, 0, 1)                           \
   V(I16x8LeU, Operator::kNoProperties, 2, 0, 1)                           \
   V(I8x16Splat, Operator::kNoProperties, 1, 0, 1)                         \
   V(I8x16Neg, Operator::kNoProperties, 1, 0, 1)                           \
   V(I8x16SConvertI16x8, Operator::kNoProperties, 2, 0, 1)                 \
   V(I8x16Add, Operator::kCommutative, 2, 0, 1)                            \
   V(I8x16AddSaturateS, Operator::kCommutative, 2, 0, 1)                   \
+  V(I8x16AddHoriz, Operator::kCommutative, 2, 0, 1)                       \
   V(I8x16Sub, Operator::kNoProperties, 2, 0, 1)                           \
   V(I8x16SubSaturateS, Operator::kNoProperties, 2, 0, 1)                  \
   V(I8x16Mul, Operator::kCommutative, 2, 0, 1)                            \
   V(I8x16MinS, Operator::kCommutative, 2, 0, 1)                           \
   V(I8x16MaxS, Operator::kCommutative, 2, 0, 1)                           \
   V(I8x16Eq, Operator::kCommutative, 2, 0, 1)                             \
   V(I8x16Ne, Operator::kCommutative, 2, 0, 1)                             \
   V(I8x16LtS, Operator::kNoProperties, 2, 0, 1)                           \
   V(I8x16LeS, Operator::kNoProperties, 2, 0, 1)                           \
   V(I8x16UConvertI16x8, Operator::kNoProperties, 2, 0, 1)                 \
@@ skipping 723 matching lines @@
 
 const Operator* MachineOperatorBuilder::S8x16Concat(int32_t bytes) {
   DCHECK(0 <= bytes && bytes < kSimd128Size);
   return new (zone_) Operator1<int32_t>(IrOpcode::kS8x16Concat, Operator::kPure,
                                         "Concat", 2, 0, 0, 1, 0, 0, bytes);
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8