ios/chrome/browser/payments/payment_request_view_controller.mm - Issue 2804853002: Cancels payment request when Settings is tapped, and opens the Autofill settings page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/payments/payment_request_view_controller.mm

Issue 2804853002: Cancels payment request when Settings is tapped, and opens the Autofill settings page. (Closed)

Patch Set: Remove more strongSelf checks. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/payments/payment_request_view_controller.mm

diff --git a/ios/chrome/browser/payments/payment_request_view_controller.mm b/ios/chrome/browser/payments/payment_request_view_controller.mm

index 714a42f03a8a56fb6dda41c00e9ec2cfc6fd58e2..5ce24aa379031fa4e9ba843f41c61dca5973662d 100644

--- a/ios/chrome/browser/payments/payment_request_view_controller.mm

+++ b/ios/chrome/browser/payments/payment_request_view_controller.mm

@@ -501,7 +501,7 @@ typedef NS_ENUM(NSInteger, ItemType) {

- (void)cell:(CollectionViewFooterCell*)cell didTapLinkURL:(GURL)url {

DCHECK_EQ(url, GURL(kSettingsURL)) << "Unknown URL tapped";

- NOTIMPLEMENTED(); // TODO(macourteau): take the user to the right place.

+ [_delegate paymentRequestViewControllerDidSelectSettings:self];

}

#pragma mark UICollectionViewDataSource