Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Side by Side Diff: content/common/worker_fetch_context_factory.mojom

Issue 2804843005: Implement the infrastructure of creating WorkerFetchContext in worker global scope. (Closed)
Patch Set: incorporated nhiroki and kinuko's comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 module content.mojom;
6
7 import "url_loader_factory.mojom";
8
9 interface ServiceWorkerClient {
10 // Called when the ServiceWorkerClient (which is Dedicated Worker or Shared
kinuko 2017/04/14 14:00:26 Too generic name if it's only for clients that liv
horo 2017/04/17 15:12:04 Done.
11 // Worker) is controlled by a new service worker.
12 SetControllerServiceWorker(int64 controller_version_id);
13 };
14
15 interface WorkerFetchContextFactory {
kinuko 2017/04/14 14:00:26 Can we also have a interface-level comment? I'm h
horo 2017/04/17 15:12:04 Done.
16 // Called from a dedicated (or shared) worker thread to create a worker fetch
17 // context.
18 // The browser process returns a URLLoaderFactory. SetControllerServiceWorker
19 // method of the passed ServiceWorkerClient interface will be called when the
20 // parent frame and the worker context is controlled by a service worker.
21 // |service_worker_provider_id| is the service worker provider id of the
22 // parent frame.
23 CreateWorkerFetchContext(associated URLLoaderFactory& loader,
24 associated ServiceWorkerClient client,
25 int32 service_worker_provider_id);
kinuko 2017/04/14 14:00:26 Similarly, this seems to be more about setting up
horo 2017/04/17 15:12:04 Does 'this' mean GetURLLoaderFactory? GetURLLoader
kinuko 2017/04/18 08:00:31 Sorry, I meant 'CreateWorkerFetchContext' one. Th
horo 2017/04/18 12:53:33 This IPC is used to get the URLLoaderFactory and r
kinuko 2017/04/19 03:24:49 This IPC is used to get the URLLoaderFactory and r
26
27 // Called from the service worker thread to get the URLLoaderFactory.
28 GetURLLoaderFactory(associated URLLoaderFactory& loader);
29 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698