Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 2804843003: Fix some crashes. (Closed)

Created:
3 years, 8 months ago by ahe
Modified:
3 years, 8 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com, Paul Berry
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Handle bad packages files and #void without crashing. R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/d515791312a10b2579080dd4f4dc5842286d3646

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -53 lines) Patch
M pkg/front_end/lib/src/fasta/fasta.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 6 chunks +10 lines, -6 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_loader.dart View 3 chunks +18 lines, -29 lines 0 comments Download
M pkg/front_end/lib/src/fasta/translate_uri.dart View 2 chunks +16 lines, -5 lines 0 comments Download
M tests/corelib/corelib.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/corelib/symbol_reserved_word_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/standalone.status View 1 chunk +3 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (4 generated)
ahe
3 years, 8 months ago (2017-04-06 08:30:13 UTC) #3
Vyacheslav Egorov (Google)
lgtm but please use a more descriptive commit message.
3 years, 8 months ago (2017-04-06 09:00:13 UTC) #4
ahe
On 2017/04/06 09:00:13, Vyacheslav Egorov (Google) wrote: > lgtm > > but please use a ...
3 years, 8 months ago (2017-04-06 10:01:34 UTC) #6
ahe
Thank you!
3 years, 8 months ago (2017-04-06 10:01:43 UTC) #7
ahe
3 years, 8 months ago (2017-04-06 10:06:01 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
d515791312a10b2579080dd4f4dc5842286d3646 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698