Handle HW encoder errors in VideoTrackRecorder

content/renderer/media_recorder/video_track_recorder_unittest.cc

Index: content/renderer/media_recorder/video_track_recorder_unittest.cc
diff --git a/content/renderer/media_recorder/video_track_recorder_unittest.cc b/content/renderer/media_recorder/video_track_recorder_unittest.cc
index d10defbb62ec93a0681b8dd9d8582e977a7092b9..f9759d70f6ff2f6e581f4313c2c12b9e19282731 100644
--- a/content/renderer/media_recorder/video_track_recorder_unittest.cc
+++ b/content/renderer/media_recorder/video_track_recorder_unittest.cc
@@ -119,6 +119,8 @@ class VideoTrackRecorderTest
     video_track_recorder_->OnVideoFrameForTesting(frame, capture_time);
   }
 
+  void OnError() { video_track_recorder_->OnError(); }
+
   bool CanEncodeAlphaChannel() {
     return video_track_recorder_->CanEncodeAlphaChannelForTesting();
   }
@@ -292,6 +294,32 @@ TEST_F(VideoTrackRecorderTest, ForceKeyframeOnAlphaSwitch) {
   Mock::VerifyAndClearExpectations(this);
 }
 
+// Inserts an OnError() call between sent frames.
+TEST_F(VideoTrackRecorderTest, HandlesOnError) {
+  InitializeRecorder(VideoTrackRecorder::CodecId::VP8);
+
+  const gfx::Size& frame_size = kTrackRecorderTestSize[0];
+  const scoped_refptr<VideoFrame> video_frame =
+      VideoFrame::CreateBlackFrame(frame_size);
+
+  InSequence s;
+  EXPECT_CALL(*this, DoOnEncodedVideo(_, _, _, _, true)).Times(1);
+  Encode(video_frame, base::TimeTicks::Now());
+
+  // Insert OnError() call.

[mcasas, 2017/04/05 22:43:40]

Superfluous comment?

Also, in this test case we don't really test much, IOW:
encode a frame, see a keyframe appearing, insert an
error, and then... just wait for another key frame? Any
other observable quality that would lead us to see the
expected changes? (Maybe we can see the track being
disconnected-reconnected?)

[emircan, 2017/04/05 23:04:36]

Right, it can have more. I added checks to make sure that encoder instance is
reset after OnError(), see HasEncoderInstance() calls. Following track events
aren't applicable here as MockMediaStreamVideoTrack isn't available.

+  OnError();
+
+  base::RunLoop run_loop;
+  base::Closure quit_closure = run_loop.QuitClosure();
+  EXPECT_CALL(*this, DoOnEncodedVideo(_, _, _, _, true))
+      .Times(1)
+      .WillOnce(RunClosure(quit_closure));
+  Encode(video_frame, base::TimeTicks::Now());
+  run_loop.Run();
+
+  Mock::VerifyAndClearExpectations(this);
+}
+
 INSTANTIATE_TEST_CASE_P(,
                         VideoTrackRecorderTest,
                         ::testing::Combine(ValuesIn(kTrackRecorderTestCodec),