Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3322)

Unified Diff: content/renderer/media_recorder/video_track_recorder.h

Issue 2804843002: Handle HW encoder errors in VideoTrackRecorder (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media_recorder/video_track_recorder.h
diff --git a/content/renderer/media_recorder/video_track_recorder.h b/content/renderer/media_recorder/video_track_recorder.h
index 1b623787919df9c2c38d8623962ff9684460aeea..43697620fb19916eb356f04e314cec46f6443bcc 100644
--- a/content/renderer/media_recorder/video_track_recorder.h
+++ b/content/renderer/media_recorder/video_track_recorder.h
@@ -54,6 +54,7 @@ class CONTENT_EXPORT VideoTrackRecorder
std::unique_ptr<std::string> encoded_alpha,
base::TimeTicks capture_timestamp,
bool is_key_frame)>;
+ using OnErrorCB = base::Callback<void(bool allow_vea_encoder)>;
mcasas 2017/04/05 21:44:33 Actually we don't need the parameter |allow_vea_en
emircan 2017/04/05 21:52:55 Done. Initially, I worked on a generic OnError() m
static CodecId GetPreferredCodecId();
@@ -74,8 +75,10 @@ class CONTENT_EXPORT VideoTrackRecorder
void InitializeEncoder(CodecId codec,
const OnEncodedVideoCB& on_encoded_video_callback,
int32_t bits_per_second,
+ bool allow_vea_encoder,
const scoped_refptr<media::VideoFrame>& frame,
base::TimeTicks capture_time);
+ void OnError(bool allow_vea_encoder);
// TODO(emircan): Remove after refactor, see http://crbug.com/700433.
bool CanEncodeAlphaChannelForTesting();
@@ -89,7 +92,8 @@ class CONTENT_EXPORT VideoTrackRecorder
// Inner class to encode using whichever codec is configured.
scoped_refptr<Encoder> encoder_;
- base::Callback<void(const scoped_refptr<media::VideoFrame>& frame,
+ base::Callback<void(bool allow_vea_encoder,
+ const scoped_refptr<media::VideoFrame>& frame,
base::TimeTicks capture_time)>
initialize_encoder_callback_;

Powered by Google App Engine
This is Rietveld 408576698