Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2804833002: fix #29228, let* precedence should match generated expression (Closed)

Created:
3 years, 8 months ago by Jennifer Messerly
Modified:
3 years, 8 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix #29228, let* precedence should match generated expression R=vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/247fc68d21fc099de51fd26b1509958d9f2154c8

Patch Set 1 #

Patch Set 2 : regen #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M pkg/dev_compiler/lib/src/compiler/code_generator.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/dev_compiler/lib/src/compiler/js_metalet.dart View 1 1 chunk +1 line, -1 line 0 comments Download
A tests/language_strong/await_and_ifnull_test.dart View 1 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jennifer Messerly
FYI, I did regenerate the SDK but it refuses to upload those files.
3 years, 8 months ago (2017-04-05 19:34:33 UTC) #2
Jennifer Messerly
On 2017/04/05 19:34:33, Jennifer Messerly wrote: > FYI, I did regenerate the SDK but it ...
3 years, 8 months ago (2017-04-05 19:35:51 UTC) #3
vsm
nice! lgtm
3 years, 8 months ago (2017-04-05 19:37:17 UTC) #4
Jennifer Messerly
3 years, 8 months ago (2017-04-05 19:40:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:10001) manually as
247fc68d21fc099de51fd26b1509958d9f2154c8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698