[Mac] Update fullscreen state when window is fullscreened natively.

chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/apps/native_app_window_cocoa.h"
 
 #import <Cocoa/Cocoa.h>
 
 #include "apps/app_window_registry.h"
 #include "chrome/browser/apps/app_browsertest_util.h"
@@ skipping 89 matching lines @@
   other_window->Hide();
   EXPECT_FALSE([other_ns_window isVisible]);
 
   // HideWithApp, ShowWithApp does not show the other window.
   window->HideWithApp();
   EXPECT_FALSE([ns_window isVisible]);
   window->ShowWithApp();
   EXPECT_TRUE([ns_window isVisible]);
   EXPECT_FALSE([other_ns_window isVisible]);
 }
+
+// Only test fullscreen for 10.7 and above.
+// Replicate specific 10.7 SDK declarations for building with prior SDKs.
+#if !defined(MAC_OS_X_VERSION_10_7) || \
+    MAC_OS_X_VERSION_MAX_ALLOWED < MAC_OS_X_VERSION_10_7
+
+@interface NSWindow (LionSDKDeclarations)
+- (void)toggleFullScreen:(id)sender;
+@end
+
+enum {
+  NSWindowCollectionBehaviorFullScreenPrimary = 1 << 7,
+  NSFullScreenWindowMask = 1 << 14
+};
+
+NSString* const NSWindowDidEnterFullScreenNotification =
+    @"NSWindowDidEnterFullScreenNotification";
+NSString* const NSWindowDidExitFullScreenNotification =
+    @"NSWindowDidExitFullScreenNotification";
+

[tapted, 2014/05/15 06:39:20]

#endif here

[jackhou1, 2014/05/15 07:15:29]

Done.

+@interface ScopedNotificationWatcher : NSObject {
+ @private
+  BOOL received_;
+}
+- (id)initWithNotification:(NSString*)notification
+                 andObject:(NSObject*)object;
+- (void)onNotification:(NSString*)notification;
+- (void)waitForNotification;
+@end
+
+@implementation ScopedNotificationWatcher
+
+- (id)initWithNotification:(NSString*)notification
+                 andObject:(NSObject*)object {
+  if ((self = [super init])) {
+    [[NSNotificationCenter defaultCenter]
+        addObserver:self
+           selector:@selector(onNotification:)
+               name:notification
+             object:object];
+  }
+  return self;
+}
+
+- (void)onNotification:(NSString*)notification {
+  received_ = YES;
+  [[NSNotificationCenter defaultCenter] removeObserver:self];
+}
+
+- (void)waitForNotification {
+  while (!received_)
+    content::RunAllPendingInMessageLoop();
+}
+
+@end
+
+// Test that NativeAppWindow and AppWindow fullscreen state is updated when
+// the window is fullscreened natively.
+IN_PROC_BROWSER_TEST_F(NativeAppWindowCocoaBrowserTest, Fullscreen) {
+  SetUpAppWithWindows(1);

[tapted, 2014/05/15 06:39:20]

here do

// Only test fullscreen for 10.7 and above.
if (base::mac::IsOSSnowLeopard())
  return;

[jackhou1, 2014/05/15 07:15:29]

Done.

+  apps::AppWindow* app_window = GetFirstAppWindow();
+  apps::NativeAppWindow* window = app_window->GetBaseWindow();
+  NSWindow* ns_window = app_window->GetNativeWindow();
+  base::scoped_nsobject<ScopedNotificationWatcher> watcher;
+
+  EXPECT_FALSE(window->IsFullscreen());
+  EXPECT_FALSE([ns_window styleMask] & NSFullScreenWindowMask);
+
+  watcher.reset([[ScopedNotificationWatcher alloc]
+      initWithNotification:NSWindowDidEnterFullScreenNotification
+                 andObject:ns_window]);
+  [ns_window toggleFullScreen:nil];
+  [watcher waitForNotification];
+  EXPECT_TRUE(window->IsFullscreen());
+  EXPECT_TRUE([ns_window styleMask] & NSFullScreenWindowMask);

[tapted, 2014/05/15 06:39:20]

I think it's worth moving `IsFullscreen` out of the anonymous namespace in
app_window.cc, and putting it as a private member function, then making this
test a friend, and doing some extra checks on AppWindow::IsFullscreen

[jackhou1, 2014/05/15 07:15:29]

Added AppWindow::fullscreen_types_for_test like app_window_contents_for_test.

+
+  watcher.reset([[ScopedNotificationWatcher alloc]
+      initWithNotification:NSWindowDidExitFullScreenNotification
+                 andObject:ns_window]);
+  app_window->Restore();

[tapted, 2014/05/15 06:39:20]

does window->IsFullscreenOrPending() change immediately, either side of this
line? (i.e. without waiting for the notification?). It should!

[jackhou1, 2014/05/15 07:15:29]

Done.

+  [watcher waitForNotification];
+  EXPECT_FALSE(window->IsFullscreen());
+  EXPECT_FALSE([ns_window styleMask] & NSFullScreenWindowMask);
+
+  watcher.reset([[ScopedNotificationWatcher alloc]
+      initWithNotification:NSWindowDidEnterFullScreenNotification
+                 andObject:ns_window]);
+  app_window->Fullscreen();
+  [watcher waitForNotification];

[tapted, 2014/05/15 06:39:20]

likewise window->IsFullscreenOrPending() should be false before this.

[jackhou1, 2014/05/15 07:15:29]

I take it you mean true? The comment on IsFullscreenOrPending says "whether the
window is fullscreen or about to enter fullscreen".

[tapted, 2014/05/15 07:44:40]

oops - yep.

+  EXPECT_TRUE(window->IsFullscreen());
+  EXPECT_TRUE([ns_window styleMask] & NSFullScreenWindowMask);
+
+  watcher.reset([[ScopedNotificationWatcher alloc]
+      initWithNotification:NSWindowDidExitFullScreenNotification
+                 andObject:ns_window]);
+  [ns_window toggleFullScreen:nil];
+  [watcher waitForNotification];

[tapted, 2014/05/15 06:39:20]

(but this one is native, so window->IsFullscreenOrPending() isn't interesting
until after the notification)

+  EXPECT_FALSE(window->IsFullscreen());
+  EXPECT_FALSE([ns_window styleMask] & NSFullScreenWindowMask);
+}
+
+#endif  // MAC_OS_X_VERSION_10_7