Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: ash/accelerators/nested_dispatcher_controller.cc

Issue 280483003: wm: Change the DispatcherClient interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix-tests Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/accelerators/nested_dispatcher_controller.cc
diff --git a/ash/accelerators/nested_dispatcher_controller.cc b/ash/accelerators/nested_dispatcher_controller.cc
index d963db07c81b9632e822a3bb221b1c6ddb7b24ef..aaf2884f2abfcebc54633baf418ec4e12f8b64be 100644
--- a/ash/accelerators/nested_dispatcher_controller.cc
+++ b/ash/accelerators/nested_dispatcher_controller.cc
@@ -18,7 +18,8 @@ NestedDispatcherController::~NestedDispatcherController() {
}
void NestedDispatcherController::RunWithDispatcher(
- base::MessagePumpDispatcher* nested_dispatcher) {
+ base::MessagePumpDispatcher* nested_dispatcher,
+ base::Closure* quit_closure) {
base::MessageLoopForUI* loop = base::MessageLoopForUI::current();
base::MessageLoopForUI::ScopedNestableTaskAllower allow_nested(loop);
@@ -26,18 +27,17 @@ void NestedDispatcherController::RunWithDispatcher(
accelerator_dispatcher_.Pass();
accelerator_dispatcher_ = AcceleratorDispatcher::Create(nested_dispatcher);
- // TODO(jbates) crbug.com/134753 Find quitters of this RunLoop and have them
- // use run_loop.QuitClosure().
scoped_ptr<base::RunLoop> run_loop = accelerator_dispatcher_->CreateRunLoop();
- base::AutoReset<base::Closure> reset_closure(&quit_closure_,
- run_loop->QuitClosure());
+ *quit_closure = base::Bind(&NestedDispatcherController::QuitNestedMessageLoop,
+ base::Unretained(this),
+ run_loop->QuitClosure());
run_loop->Run();
accelerator_dispatcher_ = old_accelerator_dispatcher.Pass();
}
-void NestedDispatcherController::QuitNestedMessageLoop() {
- CHECK(!quit_closure_.is_null());
- quit_closure_.Run();
+void NestedDispatcherController::QuitNestedMessageLoop(
+ const base::Closure& quit_runloop) {
+ quit_runloop.Run();
accelerator_dispatcher_.reset();
}

Powered by Google App Engine
This is Rietveld 408576698