Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 280483002: Add identifier for the localized text of a menulist (Closed)

Created:
6 years, 7 months ago by dtrebbien
Modified:
6 years, 7 months ago
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@issue-314704-incorrect-display-select-multiple-tag-Android
Visibility:
Public.

Description

Add identifier for the localized text of a menulist The text displayed should indicate the number of options selected. e.g. "2 selected" This CL is needed for other CLs to implement this change. BUG=314704 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174267

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M public/platform/WebLocalizedString.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
dtrebbien
6 years, 7 months ago (2014-05-11 21:51:37 UTC) #1
abarth-chromium
lgtm
6 years, 7 months ago (2014-05-12 04:31:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtrebbien@gmail.com/280483002/1
6 years, 7 months ago (2014-05-12 04:31:35 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-12 05:53:07 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-12 07:10:53 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/7183)
6 years, 7 months ago (2014-05-12 07:10:53 UTC) #6
dtrebbien
On 2014/05/12 07:10:53, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 7 months ago (2014-05-18 17:45:11 UTC) #7
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 7 months ago (2014-05-18 23:49:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtrebbien@gmail.com/280483002/1
6 years, 7 months ago (2014-05-18 23:50:02 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-19 11:43:13 UTC) #10
Message was sent while issue was closed.
Change committed as 174267

Powered by Google App Engine
This is Rietveld 408576698