Revamp the Incognito NTP on Desktop

chrome/browser/about_flags.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/about_flags.h"
 
 #include <iterator>
 #include <map>
 #include <set>
 #include <utility>
@@ skipping 1957 matching lines @@
     {"enable-md-bookmarks",
      flag_descriptions::kEnableMaterialDesignBookmarksName,
      flag_descriptions::kEnableMaterialDesignBookmarksDescription, kOsDesktop,
      FEATURE_VALUE_TYPE(features::kMaterialDesignBookmarks)},
     {"enable-md-feedback", flag_descriptions::kEnableMaterialDesignFeedbackName,
      flag_descriptions::kEnableMaterialDesignFeedbackDescription, kOsDesktop,
      SINGLE_VALUE_TYPE(switches::kEnableMaterialDesignFeedback)},
     {"enable-md-history", flag_descriptions::kEnableMaterialDesignHistoryName,
      flag_descriptions::kEnableMaterialDesignHistoryDescription, kOsDesktop,
      FEATURE_VALUE_TYPE(features::kMaterialDesignHistory)},
+    {"enable-md-incognito-ntp",

[Dan Beam, 2017/04/20 18:27:51]

fwiw: the new tab page is already material design...

if we really end up needing a feature/flag, maybe
--enable-responsive-incognito-ntp maybe?

probably doesn't matter, but it might be a little confusing

[msramek, 2017/04/21 12:20:36]

I know that the native tab UI has been materialized, but the Incognito tab
content was previously not conforming to the MD style guide (or so I was told).
We don't have a flag for MD NTP in general, so I hope this wouldn't be
confusing, and it will nicely fit with the other MD flags.

I also want to reuse the flag on Android, where "responsive" might be more
confusing, since you don't typically resize the browser window there.

And the flag is hopefully shortlived. So I would prefer to keep the name.

+     flag_descriptions::kMaterialDesignIncognitoNTPName,
+     flag_descriptions::kMaterialDesignIncognitoNTPDescription, kOsDesktop,
+     FEATURE_VALUE_TYPE(features::kMaterialDesignIncognitoNTP)},
     {"enable-md-settings", flag_descriptions::kEnableMaterialDesignSettingsName,
      flag_descriptions::kEnableMaterialDesignSettingsDescription, kOsDesktop,
      FEATURE_VALUE_TYPE(features::kMaterialDesignSettings)},
     {"safe-search-url-reporting",
      flag_descriptions::kSafeSearchUrlReportingName,
      flag_descriptions::kSafeSearchUrlReportingDescription, kOsAll,
      FEATURE_VALUE_TYPE(features::kSafeSearchUrlReporting)},
     {"force-ui-direction", flag_descriptions::kForceUiDirectionName,
      flag_descriptions::kForceUiDirectionDescription, kOsAll,
      MULTI_VALUE_TYPE(kForceUIDirectionChoices)},
@@ skipping 835 matching lines @@
 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
 
 const FeatureEntry* GetFeatureEntries(size_t* count) {
   *count = arraysize(kFeatureEntries);
   return kFeatureEntries;
 }
 
 }  // namespace testing
 
 }  // namespace about_flags