Revamp the Incognito NTP on Desktop

chrome/common/chrome_features.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file defines all the public base::FeatureList features for the chrome
 // module.
 
 #ifndef CHROME_COMMON_CHROME_FEATURES_H_
 #define CHROME_COMMON_CHROME_FEATURES_H_
 
@@ skipping 93 matching lines @@
 
 extern const base::Feature kMaterialDesignBookmarks;
 
 #if BUILDFLAG(ENABLE_EXTENSIONS)
 extern const base::Feature kMaterialDesignExtensions;
 extern const base::Feature kAcknowledgeNtpOverrideOnDeactivate;
 #endif
 
 extern const base::Feature kMaterialDesignHistory;
 
+extern const base::Feature kMaterialDesignIncognitoNTP;

[Dan Beam, 2017/04/20 18:27:51]

do we even need a flag/feature?  can this just ship?  it looks good in my local
testing.  is there much more to change?

[msramek, 2017/04/21 12:20:36]

One reason for the flag is that the strings specification has recently changed
several times over a short period of time, and in fact, we still haven't started
the translation process (which will be different than the standard translation
process as the strings are highly visible and prone to misunderstanding). So I
don't want to ship it just yet.

But I do expect to be able to remove the flag and clean up soon.

+
 extern const base::Feature kMaterialDesignSettings;
 
 #if !defined(OS_ANDROID) && !defined(OS_IOS)
 extern const base::Feature kMediaRemoting;
 extern const base::Feature kMediaRemotingEncrypted;
 #endif  // !defined(OS_ANDROID) && !defined(OS_IOS)
 
 extern const base::Feature kModalPermissionPrompts;
 
 #if defined(OS_WIN)
@@ skipping 63 matching lines @@
 #endif  // defined(OS_CHROMEOS)
 
 bool PrefServiceEnabled();
 
 // DON'T ADD RANDOM STUFF HERE. Put it in the main section above in
 // alphabetical order, or in one of the ifdefs (also in order in each section).
 
 }  // namespace features
 
 #endif  // CHROME_COMMON_CHROME_FEATURES_H_