[turbofan] Collect and use type feedback on ToNumber.

src/interpreter/interpreter-assembler.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/interpreter/interpreter-assembler.h"
 
 #include <limits>
 #include <ostream>
 
 #include "src/code-factory.h"
@@ skipping 1133 matching lines @@
       base_index = nullptr;
   }
   Node* target_index = IntPtrAdd(base_index, next_bytecode);
   Node* target_code_entry =
       Load(MachineType::Pointer(), DispatchTableRawPointer(),
            WordShl(target_index, kPointerSizeLog2));
 
   DispatchToBytecodeHandlerEntry(target_code_entry, next_bytecode_offset);
 }
 
+Node* InterpreterAssembler::ToNumberWithFeedback(Node* context, Node* object,

[rmcilroy, 2017/04/06 11:21:31]

Please just do this inline InterpreterGenerator::DoToNumber if it's not used by
any other bytecode handler.

[Michael Starzinger, 2017/04/06 11:28:31]

+1

[Benedikt Meurer, 2017/04/06 11:30:00]

Done.

+                                                 Variable* var_type_feedback) {
+  Variable var_result(this, MachineRepresentation::kTagged);
+  Label if_done(this), if_objectissmi(this), if_objectisnumber(this),
+      if_objectisother(this, Label::kDeferred);
+
+  GotoIf(TaggedIsSmi(object), &if_objectissmi);
+  Node* object_map = LoadMap(object);
+  Branch(IsHeapNumberMap(object_map), &if_objectisnumber, &if_objectisother);
+
+  Bind(&if_objectissmi);
+  {
+    var_result.Bind(object);
+    var_type_feedback->Bind(SmiConstant(BinaryOperationFeedback::kSignedSmall));
+    Goto(&if_done);
+  }
+
+  Bind(&if_objectisnumber);
+  {
+    var_result.Bind(object);
+    var_type_feedback->Bind(SmiConstant(BinaryOperationFeedback::kNumber));
+    Goto(&if_done);
+  }
+
+  Bind(&if_objectisother);
+  {
+    // Convert the {object} to a Number.
+    Callable callable = CodeFactory::NonNumberToNumber(isolate());
+    var_result.Bind(CallStub(callable, context, object));
+    var_type_feedback->Bind(SmiConstant(BinaryOperationFeedback::kAny));
+    Goto(&if_done);
+  }
+
+  Bind(&if_done);
+  return var_result.value();
+}
+
 Node* InterpreterAssembler::TruncateTaggedToWord32WithFeedback(
     Node* context, Node* value, Variable* var_type_feedback) {
   // We might need to loop once due to ToNumber conversion.
   Variable var_value(this, MachineRepresentation::kTagged),
       var_result(this, MachineRepresentation::kWord32);
   Variable* loop_vars[] = {&var_value, var_type_feedback};
   Label loop(this, 2, loop_vars), done_loop(this, &var_result);
   var_value.Bind(value);
   var_type_feedback->Bind(SmiConstant(BinaryOperationFeedback::kNone));
   Goto(&loop);
@@ skipping 258 matching lines @@
     Goto(&loop);
   }
   Bind(&done_loop);
 
   return array;
 }
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8