Don't visit a frame's code object twice.

Don't visit a frame's code object twice.

One slot in each Dart frame contains a "pc marker". Prior to the calling convention change, the pc marker was a fixed offset from the code's entry point, from which the code object could be derived. After the change, the pc marker is a pointer to the code object itself.

R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/f894b69a02e352443dae6873bbe41a34e1c4f0b4

[rmacnak, 2017-04-05 23:12:47]

rmacnak@google.com changed reviewers:
+ asiva@google.com

[rmacnak, 2017-04-05 23:12:48]

Noticed this using the stack frame visitor to do some debug printing.

[siva, 2017-04-05 23:59:30]

lgtm

[rmacnak, 2017-04-06 00:53:39]

Description was changed from

==========
Don't visit a frame's code object twice.

One slot in each Dart frame contains a "pc marker". Prior to the calling
convention change, the pc marker was a fixed offset from the code's entry point,
from which the code object could be derived. After the change, the pc marker is
a pointer to the code object itself.
==========

to

==========
Don't visit a frame's code object twice.

One slot in each Dart frame contains a "pc marker". Prior to the calling
convention change, the pc marker was a fixed offset from the code's entry point,
from which the code object could be derived. After the change, the pc marker is
a pointer to the code object itself.

R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/f894b69a02e352443dae6873bbe41a34e1c4f0b4
==========

[rmacnak, 2017-04-06 00:53:40]

Committed patchset #1 (id:1) manually as
f894b69a02e352443dae6873bbe41a34e1c4f0b4 (presubmit successful).