Chromium Code Reviews| Index: chrome/browser/ui/webui/print_preview/print_preview_handler.cc |
| diff --git a/chrome/browser/ui/webui/print_preview/print_preview_handler.cc b/chrome/browser/ui/webui/print_preview/print_preview_handler.cc |
| index f22ec21c31edb955798a638f74905ae4002f377c..6a9c1d874a3eadf177d5baae0d7b40b1ee97fc08 100644 |
| --- a/chrome/browser/ui/webui/print_preview/print_preview_handler.cc |
| +++ b/chrome/browser/ui/webui/print_preview/print_preview_handler.cc |
| @@ -1030,7 +1030,9 @@ void PrintPreviewHandler::PrintToPdf() { |
| #endif |
| base::i18n::ReplaceIllegalCharactersInPath(&print_job_title, '_'); |
| - base::FilePath default_filename(print_job_title); |
| + // Take at most 251 characters - need 4 for the extension and max length |
|
Lei Zhang
2017/04/05 20:06:07
We may want to use PATH_MAX instead. On Windows th
|
| + // on most platforms is 255. |
| + base::FilePath default_filename(print_job_title.substr(0, 251)); |
| default_filename = |
| default_filename.ReplaceExtension(FILE_PATH_LITERAL("pdf")); |