Print Preview: Fix failure to save with long page title

ui/shell_dialogs/select_file_dialog.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/shell_dialogs/select_file_dialog.h"
 
 #include <stddef.h>
+#include <algorithm>
 
 #include "base/bind.h"
 #include "base/location.h"
 #include "base/logging.h"
 #include "base/single_thread_task_runner.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "build/build_config.h"
 #include "ui/shell_dialogs/select_file_dialog_factory.h"
 #include "ui/shell_dialogs/select_file_policy.h"
 #include "ui/shell_dialogs/selected_file_info.h"
@@ skipping 73 matching lines @@
 
     // Inform the listener that no file was selected.
     // Post a task rather than calling FileSelectionCanceled directly to ensure
     // that the listener is called asynchronously.
     base::ThreadTaskRunnerHandle::Get()->PostTask(
         FROM_HERE,
         base::Bind(&SelectFileDialog::CancelFileSelection, this, params));
     return;
   }
 
+  // Shorten filename if necessary.
+  base::FilePath filename = default_path.BaseName();
+  base::FilePath path = default_path;
+  size_t max_name_length = 255;

[Lei Zhang, 2017/04/12 19:10:25]

const size_t kMaxNameLength ?

[rbpotter, 2017/04/13 00:25:02]

Done.

+  if (filename.value().length() > max_name_length) {
+    base::FilePath::StringType extension = filename.Extension();

[Lei Zhang, 2017/04/12 19:10:25]

What if the extension is 256 letters long?

[rbpotter, 2017/04/13 00:25:02]

Have addressed this in new patch.

+    path = default_path.DirName().Append(
+        filename.value().substr(0, max_name_length - extension.length()));
+    path = path.AddExtension(extension);
+  }
+
   // Call the platform specific implementation of the file selection dialog.
-  SelectFileImpl(type, title, default_path, file_types, file_type_index,
+  SelectFileImpl(type, title, path, file_types, file_type_index,
                  default_extension, owning_window, params);
 }
 
 bool SelectFileDialog::HasMultipleFileTypeChoices() {
   return HasMultipleFileTypeChoicesImpl();
 }
 
 SelectFileDialog::SelectFileDialog(Listener* listener,
                                    ui::SelectFilePolicy* policy)
     : listener_(listener),
       select_file_policy_(policy) {
   DCHECK(listener_);
 }
 
 SelectFileDialog::~SelectFileDialog() {}
 
 void SelectFileDialog::CancelFileSelection(void* params) {
   if (listener_)
     listener_->FileSelectionCanceled(params);
 }
 
 }  // namespace ui