Print Preview: Fix failure to save with long page title

chrome/browser/ui/webui/print_preview/print_preview_handler.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_WEBUI_PRINT_PREVIEW_PRINT_PREVIEW_HANDLER_H_
 #define CHROME_BROWSER_UI_WEBUI_PRINT_PREVIEW_PRINT_PREVIEW_HANDLER_H_
 
 #include <memory>
 #include <string>
 
@@ skipping 87 matching lines @@
       int http_code) override;
 #endif
 
   int regenerate_preview_request_count() const {
     return regenerate_preview_request_count_;
   }
 
   // Sets |pdf_file_saved_closure_| to |closure|.
   void SetPdfSavedClosureForTesting(const base::Closure& closure);
 
+ protected:
+  // If |prompt_user| is true, displays a modal dialog, prompting the user to
+  // select a file. Otherwise, just accept |default_path| and uniquify it.
+  // Protected so unit tests can access.
+  virtual void SelectFile(const base::FilePath& default_path, bool prompt_user);
+
+  // Handles printing to PDF. Protected to expose to unit tests.
+  void PrintToPdf();
+
+  // The underlying dialog object. Protecteed to expose to unit tests.

[Lei Zhang, 2017/04/19 21:14:07]

typo

[rbpotter, 2017/04/19 23:30:12]

Done.

+  scoped_refptr<ui::SelectFileDialog> select_file_dialog_;
+
  private:
   friend class PrintPreviewPdfGeneratedBrowserTest;
   FRIEND_TEST_ALL_PREFIXES(PrintPreviewPdfGeneratedBrowserTest,
                            MANUAL_DummyTest);
   class AccessTokenService;
 
   content::WebContents* preview_web_contents() const;
 
   PrintPreviewUI* print_preview_ui() const;
 
@@ skipping 112 matching lines @@
 
   // Send the list of printers to the Web UI.
   void SetupPrinterList(const printing::PrinterList& printer_list);
 
   // Send whether cloud print integration should be enabled.
   void SendCloudPrintEnabled();
 
   // Send the PDF data to the cloud to print.
   void SendCloudPrintJob(const base::RefCountedBytes* data);
 
-  // Handles printing to PDF.
-  void PrintToPdf();
-
   // Gets the initiator for the print preview dialog.
   content::WebContents* GetInitiator() const;
 
   // Closes the preview dialog.
   void ClosePreviewDialog();
 
   // Adds all the recorded stats taken so far to histogram counts.
   void ReportStats();
 
   // Clears initiator details for the print preview dialog.
   void ClearInitiatorDetails();
 
   // Posts a task to save |data| to pdf at |print_to_pdf_path_|.
-  void PostPrintToPdfTask();
+  virtual void PostPrintToPdfTask();

[Lei Zhang, 2017/04/19 21:14:07]

Still need to be virtual?

[rbpotter, 2017/04/19 23:30:12]

Done.

 
   // Populates |settings| according to the current locale.
   void GetNumberFormatAndMeasurementSystem(base::DictionaryValue* settings);
 
   bool GetPreviewDataAndTitle(scoped_refptr<base::RefCountedBytes>* data,
                               base::string16* title) const;
 
-  // If |prompt_user| is true, displays a modal dialog, prompting the user to
-  // select a file. Otherwise, just accept |default_path| and uniquify it.
-  void SelectFile(const base::FilePath& default_path, bool prompt_user);
-
   // Helper for getting a unique file name for SelectFile() without prompting
   // the user. Just an adaptor for FileSelected().
   void OnGotUniqueFileName(const base::FilePath& path);
 
 #if defined(USE_CUPS)
   void SaveCUPSColorSetting(const base::DictionaryValue* settings);
 
   void ConvertColorSettingToCUPSColorModel(
       base::DictionaryValue* settings) const;
 #endif
@@ skipping 59 matching lines @@
   // |success|: Whether the job succeeded.
   // |status|: The returned print job status. Useful for reporting a specific
   //     error.
   void OnExtensionPrintResult(bool success, const std::string& status);
 
   // Register/unregister from notifications of changes done to the GAIA
   // cookie.
   void RegisterForGaiaCookieChanges();
   void UnregisterForGaiaCookieChanges();
 
-  // The underlying dialog object.
-  scoped_refptr<ui::SelectFileDialog> select_file_dialog_;
-
   // A count of how many requests received to regenerate preview data.
   // Initialized to 0 then incremented and emitted to a histogram.
   int regenerate_preview_request_count_;
 
   // A count of how many requests received to show manage printers dialog.
   int manage_printers_dialog_request_count_;
   int manage_cloud_printers_dialog_request_count_;
 
   // Whether we have already logged a failed print preview.
   bool reported_failed_preview_;
@@ skipping 38 matching lines @@
   // Proxy for calls to the print backend.  Lazily initialized since web_ui() is
   // not available at construction time.
   std::unique_ptr<printing::PrinterBackendProxy> printer_backend_proxy_;
 
   base::WeakPtrFactory<PrintPreviewHandler> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(PrintPreviewHandler);
 };
 
 #endif  // CHROME_BROWSER_UI_WEBUI_PRINT_PREVIEW_PRINT_PREVIEW_HANDLER_H_