Print Preview: Fix failure to save with long page title

ui/shell_dialogs/select_file_dialog.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/shell_dialogs/select_file_dialog.h"
 
 #include <stddef.h>
+#include <algorithm>
 
 #include "base/bind.h"
 #include "base/location.h"
 #include "base/logging.h"
 #include "base/single_thread_task_runner.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "build/build_config.h"
 #include "ui/shell_dialogs/select_file_dialog_factory.h"
 #include "ui/shell_dialogs/select_file_policy.h"
 #include "ui/shell_dialogs/selected_file_info.h"
@@ skipping 60 matching lines @@
     Type type,
     const base::string16& title,
     const base::FilePath& default_path,
     const FileTypeInfo* file_types,
     int file_type_index,
     const base::FilePath::StringType& default_extension,
     gfx::NativeWindow owning_window,
     void* params) {
   DCHECK(listener_);
 
+  // Shorten filename if necessary.

[Lei Zhang, 2017/04/06 00:47:05]

Do this right before the SelectFileImpl() call. Otherwise all this calculation
may get thrown away if the code flow hits line 118.

[rbpotter, 2017/04/12 17:25:19]

Done.

+  base::FilePath filename = default_path.BaseName();
+  base::FilePath path = default_path.DirName();
+  int max_name_length = 255;

[Lei Zhang, 2017/04/06 00:47:05]

Can this be size_t to avoid all the casts below.

[rbpotter, 2017/04/12 17:25:19]

Done.

+  if (filename.value().length() > max_name_length ||
+      default_path.value().length() > MAX_PATH - 1) {

[Lei Zhang, 2017/04/06 00:47:05]

Does MAX_PATH work on POSIX?

[rbpotter, 2017/04/12 17:25:19]

Removed path length check so not an issue any more. The patch does work
on Linux, but I can't reproduce the bug on Stable there either...

+    base::FilePath::StringType extension = filename.Extension();
+    // Path name no longer than MAX_PATH - 2 - length of rest of path (remove
+    // 1 for separator and 1 for null character).
+    int max_path_length =
+        MAX_PATH - 2 - static_cast<int>(path.value().length());
+    int new_length = std::max(1, std::min(max_name_length, max_path_length) -
+                                     static_cast<int>(extension.length()));
+    path = path.Append(filename.value().substr(0, new_length));
+    path = path.AddExtension(extension);
+  } else {
+    path = path.Append(filename);

[Lei Zhang, 2017/04/06 00:47:05]

Isn't this the same as: path = default_path; ?

[rbpotter, 2017/04/12 17:25:19]

Done.

+  }
+
   if (select_file_policy_.get() &&
       !select_file_policy_->CanOpenSelectFileDialog()) {
     select_file_policy_->SelectFileDenied();
 
     // Inform the listener that no file was selected.
     // Post a task rather than calling FileSelectionCanceled directly to ensure
     // that the listener is called asynchronously.
     base::ThreadTaskRunnerHandle::Get()->PostTask(
         FROM_HERE,
         base::Bind(&SelectFileDialog::CancelFileSelection, this, params));
     return;
   }
 
   // Call the platform specific implementation of the file selection dialog.
-  SelectFileImpl(type, title, default_path, file_types, file_type_index,
+  SelectFileImpl(type, title, path, file_types, file_type_index,
                  default_extension, owning_window, params);
 }
 
 bool SelectFileDialog::HasMultipleFileTypeChoices() {
   return HasMultipleFileTypeChoicesImpl();
 }
 
 SelectFileDialog::SelectFileDialog(Listener* listener,
                                    ui::SelectFilePolicy* policy)
     : listener_(listener),
       select_file_policy_(policy) {
   DCHECK(listener_);
 }
 
 SelectFileDialog::~SelectFileDialog() {}
 
 void SelectFileDialog::CancelFileSelection(void* params) {
   if (listener_)
     listener_->FileSelectionCanceled(params);
 }
 
 }  // namespace ui