Parse type substitution comments /*=T*/ in variable declarations with Fasta.

Parse type substitution comments /*=T*/ in variable declarations with Fasta.

R=paulberry@google.com, ahe@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/07347d84fc34a475ba32bb31e04cf5e2f8c56ee4

[ahe, 2017-04-06 08:58:38]

https://codereview.chromium.org/2804753003/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/parser/parser.dart (right):

https://codereview.chromium.org/2804753003/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/parser.dart:729: token =
_injectGenericCommentTypeAssign(token);
Methods in the parser needs to be public so they can be overridden by
subclasses.

https://codereview.chromium.org/2804753003/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/parser.dart:3324: if (token.keyword ==
Keyword.VAR) {
Use this method to match keywords:

optional('var', token)

[ahe, 2017-04-06 10:04:42]

https://codereview.chromium.org/2804753003/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/parser/parser.dart (right):

https://codereview.chromium.org/2804753003/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/parser.dart:729: token =
_injectGenericCommentTypeAssign(token);
On 2017/04/06 08:58:38, ahe wrote:
> Methods in the parser needs to be public so they can be overridden by
> subclasses.

See CL 2799043004 for a detailed explanation.

https://codereview.chromium.org/2804753003/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/parser.dart:3324: if (token.keyword ==
Keyword.VAR) {
On 2017/04/06 08:58:38, ahe wrote:
> Use this method to match keywords:
> 
> optional('var', token)
> 

See lines 178-184.

[scheglov, 2017-04-06 16:15:55]

PTAL

https://codereview.chromium.org/2804753003/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/parser/parser.dart (right):

https://codereview.chromium.org/2804753003/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/parser.dart:729: token =
_injectGenericCommentTypeAssign(token);
On 2017/04/06 08:58:38, ahe wrote:
> Methods in the parser needs to be public so they can be overridden by
> subclasses.

I moved these methods to Listener.

https://codereview.chromium.org/2804753003/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/parser.dart:3324: if (token.keyword ==
Keyword.VAR) {
On 2017/04/06 08:58:38, ahe wrote:
> Use this method to match keywords:
> 
> optional('var', token)
> 

Done.

[Paul Berry, 2017-04-07 16:03:33]

lgtm

https://codereview.chromium.org/2804753003/diff/20001/pkg/analyzer/lib/src/fa...
File pkg/analyzer/lib/src/fasta/ast_builder.dart (right):

https://codereview.chromium.org/2804753003/diff/20001/pkg/analyzer/lib/src/fa...
pkg/analyzer/lib/src/fasta/ast_builder.dart:1877: Token
injectGenericCommentTypeAssign(Token token) {
I'm concerned about putting these methods in AstBuilder because the code will
have to be duplicated in BodyBuilder.

However, since Peter is out on vacation next week, I think we should land the
code as is and discuss it when he's back (and I'm in Aarhus).  I'll make a note
to talk to him about it.

Would you mind adding a TODO comment to act as an additional reminder? (e.g.
"TODO(paulberry,scheglov,ahe): figure out how to share these methods with
BodyBuilder")

[scheglov, 2017-04-07 19:58:52]

https://codereview.chromium.org/2804753003/diff/20001/pkg/analyzer/lib/src/fa...
File pkg/analyzer/lib/src/fasta/ast_builder.dart (right):

https://codereview.chromium.org/2804753003/diff/20001/pkg/analyzer/lib/src/fa...
pkg/analyzer/lib/src/fasta/ast_builder.dart:1877: Token
injectGenericCommentTypeAssign(Token token) {
On 2017/04/07 16:03:32, Paul Berry wrote:
> I'm concerned about putting these methods in AstBuilder because the code will
> have to be duplicated in BodyBuilder.
> 
> However, since Peter is out on vacation next week, I think we should land the
> code as is and discuss it when he's back (and I'm in Aarhus).  I'll make a
note
> to talk to him about it.
> 
> Would you mind adding a TODO comment to act as an additional reminder? (e.g.
> "TODO(paulberry,scheglov,ahe): figure out how to share these methods with
> BodyBuilder")

Done.

[scheglov, 2017-04-07 19:59:08]

Description was changed from

==========
Parse type substitution comments /*=T*/ in variable declarations with Fasta.

R=ahe@google.com, paulberry@google.com
BUG=
==========

to

==========
Parse type substitution comments /*=T*/ in variable declarations with Fasta.

R=paulberry@google.com, ahe@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/07347d84fc34a475ba32bb31e04cf5e2f8c56ee4
==========

[scheglov, 2017-04-07 19:59:09]

Committed patchset #2 (id:20001) manually as
07347d84fc34a475ba32bb31e04cf5e2f8c56ee4 (presubmit successful).

[ahe, 2017-05-31 14:34:18]

lgtm