Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: components/sync/engine_impl/syncer_unittest.cc

Issue 2804743004: [Sync] Restrict types to configure to only include registered types (Closed)
Patch Set: Address comments, adjust unittest. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/sync/engine_impl/syncer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync/engine_impl/syncer_unittest.cc
diff --git a/components/sync/engine_impl/syncer_unittest.cc b/components/sync/engine_impl/syncer_unittest.cc
index ca131a0e7db6102c1fbd2b5da1b383a33ad98b38..d404a3899a6f2d81afd0194c3c4b57e5b8c35216 100644
--- a/components/sync/engine_impl/syncer_unittest.cc
+++ b/components/sync/engine_impl/syncer_unittest.cc
@@ -5022,12 +5022,10 @@ TEST_F(SyncerTest, ConfigureFailsDontApplyUpdates) {
mock_server_->ClearUpdatesQueue();
}
-// Tests that, after shutdown initiated, if set of types to download includes
-// unregistered type, DCHECK doesn't get triggered.
-TEST_F(SyncerTest, ConfigureUnregisteredTypesDuringShutdown) {
- // Signal that shutdown is initiated.
- cancelation_signal_.Signal();
-
+// Tests that if type is not registered with ModelTypeRegistry (e.g. because
+// type's LoadModels failed), Syncer::ConfigureSyncShare runs without triggering
+// DCHECK.
+TEST_F(SyncerTest, ConfigureFailedUnregisteredType) {
// Simulate type being unregistered before configuration by including type
// that isn't registered with ModelTypeRegistry.
SyncShareConfigureTypes(ModelTypeSet(APPS));
« no previous file with comments | « components/sync/engine_impl/syncer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698