Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 2804733002: Fix crash in PPAPI Flash DRM (Closed)

Created:
3 years, 8 months ago by khmel
Modified:
3 years, 8 months ago
Reviewers:
bbudge, raymes
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash in PPAPI Flash DRM Based on set of crash reports this happens in Windows while accessing monitor id. In that cases Render Frame Host has empty view. This CL handles this case. BUG=704832 TEST=N/A. I tried various scenarios but could not reproduce. So fix is based only on crashes analysis. Review-Url: https://codereview.chromium.org/2804733002 Cr-Commit-Position: refs/heads/master@{#462145} Committed: https://chromium.googlesource.com/chromium/src/+/806eccb360b6d7ddbe0b10c35e55d33c5a4b6539

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/renderer_host/pepper/pepper_flash_drm_host.cc View 1 chunk +2 lines, -0 lines 1 comment Download

Messages

Total messages: 16 (9 generated)
khmel
Hi, PTAL Thanks! https://codereview.chromium.org/2804733002/diff/1/chrome/browser/renderer_host/pepper/pepper_flash_drm_host.cc File chrome/browser/renderer_host/pepper/pepper_flash_drm_host.cc (right): https://codereview.chromium.org/2804733002/diff/1/chrome/browser/renderer_host/pepper/pepper_flash_drm_host.cc#newcode86 chrome/browser/renderer_host/pepper/pepper_flash_drm_host.cc:86: aura::WindowTreeHost* host = native_view->GetHost(); Crash happens ...
3 years, 8 months ago (2017-04-05 16:14:12 UTC) #2
bbudge
lgtm
3 years, 8 months ago (2017-04-05 17:05:59 UTC) #3
khmel
Thanks for review!
3 years, 8 months ago (2017-04-05 17:06:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804733002/1
3 years, 8 months ago (2017-04-05 17:07:42 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/422578)
3 years, 8 months ago (2017-04-05 17:43:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804733002/1
3 years, 8 months ago (2017-04-05 17:45:12 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 18:09:41 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/806eccb360b6d7ddbe0b10c35e55...

Powered by Google App Engine
This is Rietveld 408576698