Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Unified Diff: ui/latency/ipc/latency_info_param_traits_unittest.cc

Issue 2804693002: Remove coordinates from LatencyInfo objects. (Closed)
Patch Set: Fix fuzzer test Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/latency/ipc/latency_info_param_traits_unittest.cc
diff --git a/ui/latency/ipc/latency_info_param_traits_unittest.cc b/ui/latency/ipc/latency_info_param_traits_unittest.cc
index 0ffb1b46296680763e200838478ba3704c637992..b41a10ad8c66ab323f3fc3ade730a73b65b070db 100644
--- a/ui/latency/ipc/latency_info_param_traits_unittest.cc
+++ b/ui/latency/ipc/latency_info_param_traits_unittest.cc
@@ -16,19 +16,13 @@ namespace ui {
TEST(LatencyInfoParamTraitsTest, Basic) {
LatencyInfo latency;
ASSERT_FALSE(latency.terminated());
- ASSERT_EQ(0u, latency.input_coordinates_size());
latency.AddLatencyNumber(INPUT_EVENT_LATENCY_ORIGINAL_COMPONENT, 1234, 0);
latency.AddLatencyNumber(INPUT_EVENT_LATENCY_BEGIN_RWH_COMPONENT, 1234, 100);
latency.AddLatencyNumber(INPUT_EVENT_LATENCY_TERMINATED_FRAME_SWAP_COMPONENT,
1234, 0);
- EXPECT_TRUE(latency.AddInputCoordinate(gfx::PointF(100, 200)));
- EXPECT_TRUE(latency.AddInputCoordinate(gfx::PointF(101, 201)));
- // Up to 2 InputCoordinate is allowed.
- EXPECT_FALSE(latency.AddInputCoordinate(gfx::PointF(102, 202)));
EXPECT_EQ(100, latency.trace_id());
EXPECT_TRUE(latency.terminated());
- EXPECT_EQ(2u, latency.input_coordinates_size());
IPC::Message msg(1, 2, IPC::Message::PRIORITY_NORMAL);
IPC::WriteParam(&msg, latency);
@@ -38,13 +32,6 @@ TEST(LatencyInfoParamTraitsTest, Basic) {
EXPECT_EQ(latency.trace_id(), output.trace_id());
EXPECT_EQ(latency.terminated(), output.terminated());
- EXPECT_EQ(latency.input_coordinates_size(), output.input_coordinates_size());
- for (size_t i = 0; i < latency.input_coordinates_size(); i++) {
- EXPECT_EQ(latency.input_coordinates()[i].x(),
- output.input_coordinates()[i].x());
- EXPECT_EQ(latency.input_coordinates()[i].y(),
- output.input_coordinates()[i].y());
- }
EXPECT_TRUE(output.FindLatency(INPUT_EVENT_LATENCY_ORIGINAL_COMPONENT,
1234,
@@ -66,9 +53,6 @@ TEST(LatencyInfoParamTraitsTest, InvalidData) {
IPC::WriteParam(&msg, std::string());
ui::LatencyInfo::LatencyMap components;
IPC::WriteParam(&msg, components);
- // input_coordinates_size is 2 but only one InputCoordinate is written.
- IPC::WriteParam(&msg, static_cast<uint32_t>(2));
- IPC::WriteParam(&msg, gfx::PointF());
IPC::WriteParam(&msg, static_cast<int64_t>(1234));
IPC::WriteParam(&msg, true);

Powered by Google App Engine
This is Rietveld 408576698