Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(909)

Unified Diff: ui/latency/latency_info.cc

Issue 2804693002: Remove coordinates from LatencyInfo objects. (Closed)
Patch Set: Fix mojo latencyInfo test Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/latency/latency_info.h ('k') | ui/latency/mojo/latency_info.mojom » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/latency/latency_info.cc
diff --git a/ui/latency/latency_info.cc b/ui/latency/latency_info.cc
index 0d5d111031307a95ad64aaeedb9bacc095b9a6b6..9427c4ccc308e9eaa71f9a60b5b5df36b69c1cd6 100644
--- a/ui/latency/latency_info.cc
+++ b/ui/latency/latency_info.cc
@@ -133,8 +133,7 @@ namespace ui {
LatencyInfo::LatencyInfo() : LatencyInfo(SourceEventType::UNKNOWN) {}
LatencyInfo::LatencyInfo(SourceEventType type)
- : input_coordinates_size_(0),
- trace_id_(-1),
+ : trace_id_(-1),
coalesced_(false),
terminated_(false),
source_event_type_(type) {}
@@ -144,8 +143,7 @@ LatencyInfo::LatencyInfo(const LatencyInfo& other) = default;
LatencyInfo::~LatencyInfo() {}
LatencyInfo::LatencyInfo(int64_t trace_id, bool terminated)
- : input_coordinates_size_(0),
- trace_id_(trace_id),
+ : trace_id_(trace_id),
terminated_(terminated),
source_event_type_(SourceEventType::UNKNOWN) {}
@@ -295,11 +293,9 @@ void LatencyInfo::AddLatencyNumberWithTimestampImpl(
terminated_ = true;
if (*latency_info_enabled) {
- TRACE_EVENT_COPY_ASYNC_END2(kTraceCategoriesForAsyncEvents,
- trace_name_.c_str(),
- TRACE_ID_DONT_MANGLE(trace_id_),
- "data", AsTraceableData(),
- "coordinates", CoordinatesAsTraceableData());
+ TRACE_EVENT_COPY_ASYNC_END1(
+ kTraceCategoriesForAsyncEvents, trace_name_.c_str(),
+ TRACE_ID_DONT_MANGLE(trace_id_), "data", AsTraceableData());
}
TRACE_EVENT_WITH_FLOW0("input,benchmark",
@@ -330,19 +326,6 @@ LatencyInfo::AsTraceableData() {
return LatencyInfoTracedValue::FromValue(std::move(record_data));
}
-std::unique_ptr<base::trace_event::ConvertableToTraceFormat>
-LatencyInfo::CoordinatesAsTraceableData() {
- std::unique_ptr<base::ListValue> coordinates(new base::ListValue());
- for (size_t i = 0; i < input_coordinates_size_; i++) {
- std::unique_ptr<base::DictionaryValue> coordinate_pair(
- new base::DictionaryValue());
- coordinate_pair->SetDouble("x", input_coordinates_[i].x());
- coordinate_pair->SetDouble("y", input_coordinates_[i].y());
- coordinates->Append(std::move(coordinate_pair));
- }
- return LatencyInfoTracedValue::FromValue(std::move(coordinates));
-}
-
bool LatencyInfo::FindLatency(LatencyComponentType type,
int64_t id,
LatencyComponent* output) const {
@@ -379,11 +362,4 @@ void LatencyInfo::RemoveLatency(LatencyComponentType type) {
}
}
-bool LatencyInfo::AddInputCoordinate(const gfx::PointF& input_coordinate) {
- if (input_coordinates_size_ >= kMaxInputCoordinates)
- return false;
- input_coordinates_[input_coordinates_size_++] = input_coordinate;
- return true;
-}
-
} // namespace ui
« no previous file with comments | « ui/latency/latency_info.h ('k') | ui/latency/mojo/latency_info.mojom » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698