Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: chrome/browser/about_flags.cc

Issue 2804633003: Add base::FeatureParam<> struct (Closed)
Patch Set: Remove windows-incompatible constexpr Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 2bc95f6c3ec802f49dabe17537878ee69a0e9f74..3d7c74e29927e26dea4500fb20ce1713c19b62b7 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -537,13 +537,13 @@ const FeatureEntry::Choice kAshForceTabletModeChoices[] = {
#if defined(OS_ANDROID)
const FeatureEntry::FeatureParam
kContentSuggestionsCategoryOrderFeatureVariationGeneral[] = {
- {ntp_snippets::kCategoryOrderParameter,
+ {ntp_snippets::kCategoryOrderParameter.name,
ntp_snippets::kCategoryOrderGeneral},
};
const FeatureEntry::FeatureParam
kContentSuggestionsCategoryOrderFeatureVariationEMOriented[] = {
- {ntp_snippets::kCategoryOrderParameter,
+ {ntp_snippets::kCategoryOrderParameter.name,
ntp_snippets::kCategoryOrderEmergingMarketsOriented},
};
@@ -559,13 +559,13 @@ const FeatureEntry::FeatureVariation
const FeatureEntry::FeatureParam
kContentSuggestionsCategoryRankerFeatureVariationConstant[] = {
- {ntp_snippets::kCategoryRankerParameter,
+ {ntp_snippets::kCategoryRankerParameter.name,
ntp_snippets::kCategoryRankerConstantRanker},
};
const FeatureEntry::FeatureParam
kContentSuggestionsCategoryRankerFeatureVariationClickBased[] = {
- {ntp_snippets::kCategoryRankerParameter,
+ {ntp_snippets::kCategoryRankerParameter.name,
ntp_snippets::kCategoryRankerClickBasedRanker},
};

Powered by Google App Engine
This is Rietveld 408576698