Add base::FeatureParam<> struct

components/ntp_snippets/remote/request_throttler.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/ntp_snippets/remote/request_throttler.h"
 
 #include <climits>
 #include <set>
 #include <vector>
 
@@ skipping 27 matching lines @@
 // Quota value to use if no quota should be applied (by default).
 const int kUnlimitedQuota = INT_MAX;
 
 }  // namespace
 
 struct RequestThrottler::RequestTypeInfo {
   const char* name;
   const char* count_pref;
   const char* interactive_count_pref;
   const char* day_pref;
-  const int default_quota;
-  const int default_interactive_quota;
+  const base::FeatureParam<int> quota;
+  const base::FeatureParam<int> interactive_quota;
 };
 
 // When adding a new type here, extend also the "RequestThrottlerTypes"
 // <histogram_suffixes> in histograms.xml with the |name| string.
 const RequestThrottler::RequestTypeInfo RequestThrottler::kRequestTypeInfo[] = {
     // The following three types share the same prefs. They differ in quota
     // values (and UMA histograms).
-    // RequestCounter::RequestType::CONTENT_SUGGESTION_FETCHER_RARE_NTP_USER,
-    {"SuggestionFetcherRareNTPUser", prefs::kSnippetFetcherRequestCount,
+    // RequestCounter::RequestType::
+    //     CONTENT_SUGGESTION_FETCHER_RARE_NTP_USER,
+    {"SuggestionFetcherRareNTPUser",
+     prefs::kSnippetFetcherRequestCount,
      prefs::kSnippetFetcherInteractiveRequestCount,
-     prefs::kSnippetFetcherRequestsDay, 5, kUnlimitedQuota},
-    // RequestCounter::RequestType::CONTENT_SUGGESTION_FETCHER_ACTIVE_NTP_USER,
-    {"SuggestionFetcherActiveNTPUser", prefs::kSnippetFetcherRequestCount,
+     prefs::kSnippetFetcherRequestsDay,
+     {&kArticleSuggestionsFeature, "quota_SuggestionFetcherRareNTPUser", 5},
+     {&kArticleSuggestionsFeature,
+      "interactive_quota_SuggestionFetcherRareNTPUser", kUnlimitedQuota}},
+    // RequestCounter::RequestType::
+    //     CONTENT_SUGGESTION_FETCHER_ACTIVE_NTP_USER,
+    {"SuggestionFetcherActiveNTPUser",
+     prefs::kSnippetFetcherRequestCount,
      prefs::kSnippetFetcherInteractiveRequestCount,
-     prefs::kSnippetFetcherRequestsDay, 20, kUnlimitedQuota},
-    // RequestCounter::RequestType::CONTENT_SUGGESTION_FETCHER_ACTIVE_SUGGESTIONS_CONSUMER,
+     prefs::kSnippetFetcherRequestsDay,
+     {&kArticleSuggestionsFeature, "quota_SuggestionFetcherActiveNTPUser", 20},
+     {&kArticleSuggestionsFeature,
+      "interactive_quota_SuggestionFetcherActiveNTPUser", kUnlimitedQuota}},
+    // RequestCounter::RequestType::
+    //     CONTENT_SUGGESTION_FETCHER_ACTIVE_SUGGESTIONS_CONSUMER,
     {"SuggestionFetcherActiveSuggestionsConsumer",
      prefs::kSnippetFetcherRequestCount,
      prefs::kSnippetFetcherInteractiveRequestCount,
-     prefs::kSnippetFetcherRequestsDay, 20, kUnlimitedQuota},
+     prefs::kSnippetFetcherRequestsDay,
+     {&kArticleSuggestionsFeature,
+      "quota_SuggestionFetcherActiveSuggestionsConsumer", 20},
+     {&kArticleSuggestionsFeature,
+      "interactive_quota_SuggestionFetcherActiveSuggestionsConsumer",
+      kUnlimitedQuota}},
     // RequestCounter::RequestType::CONTENT_SUGGESTION_THUMBNAIL,
-    {"SuggestionThumbnailFetcher", prefs::kSnippetThumbnailsRequestCount,
+    {"SuggestionThumbnailFetcher",
+     prefs::kSnippetThumbnailsRequestCount,
      prefs::kSnippetThumbnailsInteractiveRequestCount,
-     prefs::kSnippetThumbnailsRequestsDay, kUnlimitedQuota, kUnlimitedQuota}};
+     prefs::kSnippetThumbnailsRequestsDay,
+     {&kArticleSuggestionsFeature, "quota_SuggestionThumbnailFetcher",
+      kUnlimitedQuota},
+     {&kArticleSuggestionsFeature,
+      "interactive_quota_SuggestionThumbnailFetcher", kUnlimitedQuota}}};
 
 RequestThrottler::RequestThrottler(PrefService* pref_service, RequestType type)
     : pref_service_(pref_service),
       type_info_(kRequestTypeInfo[static_cast<int>(type)]) {
   DCHECK(pref_service);
 
-  std::string quota = variations::GetVariationParamValueByFeature(
-      ntp_snippets::kArticleSuggestionsFeature,
-      base::StringPrintf("quota_%s", GetRequestTypeName()));
-  if (!base::StringToInt(quota, &quota_)) {
-    LOG_IF(WARNING, !quota.empty())
-        << "Invalid variation parameter for quota for " << GetRequestTypeName();
-    quota_ = type_info_.default_quota;
-  }
-
-  std::string interactive_quota = variations::GetVariationParamValueByFeature(
-      ntp_snippets::kArticleSuggestionsFeature,
-      base::StringPrintf("interactive_quota_%s", GetRequestTypeName()));
-  if (!base::StringToInt(interactive_quota, &interactive_quota_)) {
-    LOG_IF(WARNING, !interactive_quota.empty())
-        << "Invalid variation parameter for interactive quota for "
-        << GetRequestTypeName();
-    interactive_quota_ = type_info_.default_interactive_quota;
-  }
+  quota_ = type_info_.quota.Get();
+  interactive_quota_ = type_info_.interactive_quota.Get();
 
   // Since the histogram names are dynamic, we cannot use the standard macros
   // and we need to lookup the histograms, instead.
   int status_count = static_cast<int>(RequestStatus::REQUEST_STATUS_COUNT);
   // Corresponds to UMA_HISTOGRAM_ENUMERATION(name, sample, |status_count|).
   histogram_request_status_ = base::LinearHistogram::FactoryGet(
       base::StringPrintf("NewTabPage.RequestThrottler.RequestStatus_%s",
                          GetRequestTypeName()),
       1, status_count, status_count + 1,
       base::HistogramBase::kUmaTargetedHistogramFlag);
@@ skipping 94 matching lines @@
 
 void RequestThrottler::SetDay(int day) {
   pref_service_->SetInteger(type_info_.day_pref, day);
 }
 
 bool RequestThrottler::HasDay() const {
   return pref_service_->HasPrefPath(type_info_.day_pref);
 }
 
 }  // namespace ntp_snippets