Add base::FeatureParam<> struct

components/ntp_snippets/remote/json_request.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/ntp_snippets/remote/json_request.h"
 
 #include <algorithm>
 #include <utility>
 #include <vector>
 
@@ skipping 31 matching lines @@
 using net::HttpRequestHeaders;
 using net::URLRequestStatus;
 using translate::LanguageModel;
 
 namespace ntp_snippets {
 
 namespace internal {
 
 namespace {
 
-// Variation parameter for disabling the retry.
-const char kBackground5xxRetriesName[] = "background_5xx_retries_count";
+constexpr base::FeatureParam<int> kBackground5xxRetries{
+    &ntp_snippets::kArticleSuggestionsFeature, "background_5xx_retries_count",
+    0};
 
 const int kMaxExcludedIds = 100;
 
 // Variation parameter for sending LanguageModel info to the server.
-const char kSendTopLanguagesName[] = "send_top_languages";
+constexpr base::FeatureParam<bool> kSendTopLanguagesParam{
+    &kArticleSuggestionsFeature, "send_top_languages", true};
 
 // Variation parameter for sending UserClassifier info to the server.
-const char kSendUserClassName[] = "send_user_class";
+constexpr base::FeatureParam<bool> kSendUserClassNameParam{
+    &kArticleSuggestionsFeature, "send_user_class", false};
 
 int Get5xxRetryCount(bool interactive_request) {
   if (interactive_request) {
     return 2;
   }
-  return std::max(0, variations::GetVariationParamByFeatureAsInt(
-                         ntp_snippets::kArticleSuggestionsFeature,
-                         kBackground5xxRetriesName, 0));
-}
-
-bool IsSendingTopLanguagesEnabled() {
-  return variations::GetVariationParamByFeatureAsBool(
-      ntp_snippets::kArticleSuggestionsFeature, kSendTopLanguagesName,
-      /*default_value=*/true);
-}
-
-bool IsSendingUserClassEnabled() {
-  return variations::GetVariationParamByFeatureAsBool(
-      ntp_snippets::kArticleSuggestionsFeature, kSendUserClassName,
-      /*default_value=*/false);
+  return std::max(0, kBackground5xxRetries.Get());
 }
 
 // Translate the BCP 47 |language_code| into a posix locale string.
 std::string PosixLocaleFromBCP47Language(const std::string& language_code) {
   char locale[ULOC_FULLNAME_CAPACITY];
   UErrorCode error = U_ZERO_ERROR;
   // Translate the input to a posix locale.
   uloc_forLanguageTag(language_code.c_str(), locale, ULOC_FULLNAME_CAPACITY,
                       nullptr, &error);
   if (error != U_ZERO_ERROR) {
@@ skipping 185 matching lines @@
 }
 
 JsonRequest::Builder& JsonRequest::Builder::SetUrlRequestContextGetter(
     const scoped_refptr<net::URLRequestContextGetter>& context_getter) {
   url_request_context_getter_ = context_getter;
   return *this;
 }
 
 JsonRequest::Builder& JsonRequest::Builder::SetUserClassifier(
     const UserClassifier& user_classifier) {
-  if (IsSendingUserClassEnabled()) {
+  if (kSendUserClassNameParam.Get()) {
     user_class_ = GetUserClassString(user_classifier.GetUserClass());
   }
   return *this;
 }
 
 std::string JsonRequest::Builder::BuildHeaders() const {
   net::HttpRequestHeaders headers;
   headers.SetHeader("Content-Type", "application/json; charset=UTF-8");
   if (!auth_header_.empty()) {
     headers.SetHeader("Authorization", auth_header_);
@@ skipping 107 matching lines @@
       Get5xxRetryCount(params_.interactive_request));
   return url_fetcher;
 }
 
 void JsonRequest::Builder::PrepareLanguages(
     translate::LanguageModel::LanguageInfo* ui_language,
     translate::LanguageModel::LanguageInfo* other_top_language) const {
   // TODO(jkrcal): Add language model factory for iOS and add fakes to tests so
   // that |language_model| is never nullptr. Remove this check and add a DCHECK
   // into the constructor.
-  if (!language_model_ || !IsSendingTopLanguagesEnabled()) {
+  if (!language_model_ || !kSendTopLanguagesParam.Get()) {
     return;
   }
 
   // TODO(jkrcal): Is this back-and-forth converting necessary?
   ui_language->language_code = ISO639FromPosixLocale(
       PosixLocaleFromBCP47Language(params_.language_code));
   ui_language->frequency =
       language_model_->GetLanguageFrequency(ui_language->language_code);
 
   std::vector<LanguageModel::LanguageInfo> top_languages =
@@ skipping 12 matching lines @@
           "NewTabPage.Languages.UILanguageRatioInTwoTopLanguages",
           ratio_ui_in_both_languages * 100);
       break;
     }
   }
 }
 
 }  // namespace internal
 
 }  // namespace ntp_snippets