Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2804633003: Add base::FeatureParam<> struct (Closed)
Patch Set: Remove windows-incompatible constexpr Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 519 matching lines...) Expand 10 before | Expand all | Expand 10 after
530 ash::switches::kAshForceTabletModeClamshell}, 530 ash::switches::kAshForceTabletModeClamshell},
531 {flag_descriptions::kForceTabletModeAuto, 531 {flag_descriptions::kForceTabletModeAuto,
532 ash::switches::kAshForceTabletMode, 532 ash::switches::kAshForceTabletMode,
533 ash::switches::kAshForceTabletModeAuto}, 533 ash::switches::kAshForceTabletModeAuto},
534 }; 534 };
535 #endif // OS_CHROMEOS 535 #endif // OS_CHROMEOS
536 536
537 #if defined(OS_ANDROID) 537 #if defined(OS_ANDROID)
538 const FeatureEntry::FeatureParam 538 const FeatureEntry::FeatureParam
539 kContentSuggestionsCategoryOrderFeatureVariationGeneral[] = { 539 kContentSuggestionsCategoryOrderFeatureVariationGeneral[] = {
540 {ntp_snippets::kCategoryOrderParameter, 540 {ntp_snippets::kCategoryOrderParameter.name,
541 ntp_snippets::kCategoryOrderGeneral}, 541 ntp_snippets::kCategoryOrderGeneral},
542 }; 542 };
543 543
544 const FeatureEntry::FeatureParam 544 const FeatureEntry::FeatureParam
545 kContentSuggestionsCategoryOrderFeatureVariationEMOriented[] = { 545 kContentSuggestionsCategoryOrderFeatureVariationEMOriented[] = {
546 {ntp_snippets::kCategoryOrderParameter, 546 {ntp_snippets::kCategoryOrderParameter.name,
547 ntp_snippets::kCategoryOrderEmergingMarketsOriented}, 547 ntp_snippets::kCategoryOrderEmergingMarketsOriented},
548 }; 548 };
549 549
550 const FeatureEntry::FeatureVariation 550 const FeatureEntry::FeatureVariation
551 kContentSuggestionsCategoryOrderFeatureVariations[] = { 551 kContentSuggestionsCategoryOrderFeatureVariations[] = {
552 {"(general)", kContentSuggestionsCategoryOrderFeatureVariationGeneral, 552 {"(general)", kContentSuggestionsCategoryOrderFeatureVariationGeneral,
553 arraysize(kContentSuggestionsCategoryOrderFeatureVariationGeneral), 553 arraysize(kContentSuggestionsCategoryOrderFeatureVariationGeneral),
554 nullptr}, 554 nullptr},
555 {"(emerging markets oriented)", 555 {"(emerging markets oriented)",
556 kContentSuggestionsCategoryOrderFeatureVariationEMOriented, 556 kContentSuggestionsCategoryOrderFeatureVariationEMOriented,
557 arraysize(kContentSuggestionsCategoryOrderFeatureVariationEMOriented), 557 arraysize(kContentSuggestionsCategoryOrderFeatureVariationEMOriented),
558 nullptr}}; 558 nullptr}};
559 559
560 const FeatureEntry::FeatureParam 560 const FeatureEntry::FeatureParam
561 kContentSuggestionsCategoryRankerFeatureVariationConstant[] = { 561 kContentSuggestionsCategoryRankerFeatureVariationConstant[] = {
562 {ntp_snippets::kCategoryRankerParameter, 562 {ntp_snippets::kCategoryRankerParameter.name,
563 ntp_snippets::kCategoryRankerConstantRanker}, 563 ntp_snippets::kCategoryRankerConstantRanker},
564 }; 564 };
565 565
566 const FeatureEntry::FeatureParam 566 const FeatureEntry::FeatureParam
567 kContentSuggestionsCategoryRankerFeatureVariationClickBased[] = { 567 kContentSuggestionsCategoryRankerFeatureVariationClickBased[] = {
568 {ntp_snippets::kCategoryRankerParameter, 568 {ntp_snippets::kCategoryRankerParameter.name,
569 ntp_snippets::kCategoryRankerClickBasedRanker}, 569 ntp_snippets::kCategoryRankerClickBasedRanker},
570 }; 570 };
571 571
572 const FeatureEntry::FeatureVariation 572 const FeatureEntry::FeatureVariation
573 kContentSuggestionsCategoryRankerFeatureVariations[] = { 573 kContentSuggestionsCategoryRankerFeatureVariations[] = {
574 {"(constant)", 574 {"(constant)",
575 kContentSuggestionsCategoryRankerFeatureVariationConstant, 575 kContentSuggestionsCategoryRankerFeatureVariationConstant,
576 arraysize(kContentSuggestionsCategoryRankerFeatureVariationConstant), 576 arraysize(kContentSuggestionsCategoryRankerFeatureVariationConstant),
577 nullptr}, 577 nullptr},
578 {"(click based)", 578 {"(click based)",
(...skipping 2142 matching lines...) Expand 10 before | Expand all | Expand 10 after
2721 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2721 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2722 2722
2723 const FeatureEntry* GetFeatureEntries(size_t* count) { 2723 const FeatureEntry* GetFeatureEntries(size_t* count) {
2724 *count = arraysize(kFeatureEntries); 2724 *count = arraysize(kFeatureEntries);
2725 return kFeatureEntries; 2725 return kFeatureEntries;
2726 } 2726 }
2727 2727
2728 } // namespace testing 2728 } // namespace testing
2729 2729
2730 } // namespace about_flags 2730 } // namespace about_flags
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698