Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2804633003: Add base::FeatureParam<> struct (Closed)
Patch Set: rebase Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 647 matching lines...) Expand 10 before | Expand all | Expand 10 after
658 {flag_descriptions::kUiModeClamshell, ash::switches::kAshUiMode, 658 {flag_descriptions::kUiModeClamshell, ash::switches::kAshUiMode,
659 ash::switches::kAshUiModeClamshell}, 659 ash::switches::kAshUiModeClamshell},
660 {flag_descriptions::kUiModeAuto, ash::switches::kAshUiMode, 660 {flag_descriptions::kUiModeAuto, ash::switches::kAshUiMode,
661 ash::switches::kAshUiModeAuto}, 661 ash::switches::kAshUiModeAuto},
662 }; 662 };
663 #endif // OS_CHROMEOS 663 #endif // OS_CHROMEOS
664 664
665 #if defined(OS_ANDROID) 665 #if defined(OS_ANDROID)
666 const FeatureEntry::FeatureParam 666 const FeatureEntry::FeatureParam
667 kContentSuggestionsCategoryOrderFeatureVariationGeneral[] = { 667 kContentSuggestionsCategoryOrderFeatureVariationGeneral[] = {
668 {ntp_snippets::kCategoryOrderParameter, 668 {ntp_snippets::kCategoryOrderParameter.name,
669 ntp_snippets::kCategoryOrderGeneral}, 669 ntp_snippets::kCategoryOrderGeneral},
670 }; 670 };
671 671
672 const FeatureEntry::FeatureParam 672 const FeatureEntry::FeatureParam
673 kContentSuggestionsCategoryOrderFeatureVariationEMOriented[] = { 673 kContentSuggestionsCategoryOrderFeatureVariationEMOriented[] = {
674 {ntp_snippets::kCategoryOrderParameter, 674 {ntp_snippets::kCategoryOrderParameter.name,
675 ntp_snippets::kCategoryOrderEmergingMarketsOriented}, 675 ntp_snippets::kCategoryOrderEmergingMarketsOriented},
676 }; 676 };
677 677
678 const FeatureEntry::FeatureVariation 678 const FeatureEntry::FeatureVariation
679 kContentSuggestionsCategoryOrderFeatureVariations[] = { 679 kContentSuggestionsCategoryOrderFeatureVariations[] = {
680 {"(general)", kContentSuggestionsCategoryOrderFeatureVariationGeneral, 680 {"(general)", kContentSuggestionsCategoryOrderFeatureVariationGeneral,
681 arraysize(kContentSuggestionsCategoryOrderFeatureVariationGeneral), 681 arraysize(kContentSuggestionsCategoryOrderFeatureVariationGeneral),
682 nullptr}, 682 nullptr},
683 {"(emerging markets oriented)", 683 {"(emerging markets oriented)",
684 kContentSuggestionsCategoryOrderFeatureVariationEMOriented, 684 kContentSuggestionsCategoryOrderFeatureVariationEMOriented,
685 arraysize(kContentSuggestionsCategoryOrderFeatureVariationEMOriented), 685 arraysize(kContentSuggestionsCategoryOrderFeatureVariationEMOriented),
686 nullptr}}; 686 nullptr}};
687 687
688 const FeatureEntry::FeatureParam 688 const FeatureEntry::FeatureParam
689 kContentSuggestionsCategoryRankerFeatureVariationConstant[] = { 689 kContentSuggestionsCategoryRankerFeatureVariationConstant[] = {
690 {ntp_snippets::kCategoryRankerParameter, 690 {ntp_snippets::kCategoryRankerParameter.name,
691 ntp_snippets::kCategoryRankerConstantRanker}, 691 ntp_snippets::kCategoryRankerConstantRanker},
692 }; 692 };
693 693
694 const FeatureEntry::FeatureParam 694 const FeatureEntry::FeatureParam
695 kContentSuggestionsCategoryRankerFeatureVariationClickBased[] = { 695 kContentSuggestionsCategoryRankerFeatureVariationClickBased[] = {
696 {ntp_snippets::kCategoryRankerParameter, 696 {ntp_snippets::kCategoryRankerParameter.name,
697 ntp_snippets::kCategoryRankerClickBasedRanker}, 697 ntp_snippets::kCategoryRankerClickBasedRanker},
698 }; 698 };
699 699
700 const FeatureEntry::FeatureVariation 700 const FeatureEntry::FeatureVariation
701 kContentSuggestionsCategoryRankerFeatureVariations[] = { 701 kContentSuggestionsCategoryRankerFeatureVariations[] = {
702 {"(constant)", 702 {"(constant)",
703 kContentSuggestionsCategoryRankerFeatureVariationConstant, 703 kContentSuggestionsCategoryRankerFeatureVariationConstant,
704 arraysize(kContentSuggestionsCategoryRankerFeatureVariationConstant), 704 arraysize(kContentSuggestionsCategoryRankerFeatureVariationConstant),
705 nullptr}, 705 nullptr},
706 {"(click based)", 706 {"(click based)",
(...skipping 2918 matching lines...) Expand 10 before | Expand all | Expand 10 after
3625 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 3625 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
3626 3626
3627 const FeatureEntry* GetFeatureEntries(size_t* count) { 3627 const FeatureEntry* GetFeatureEntries(size_t* count) {
3628 *count = arraysize(kFeatureEntries); 3628 *count = arraysize(kFeatureEntries);
3629 return kFeatureEntries; 3629 return kFeatureEntries;
3630 } 3630 }
3631 3631
3632 } // namespace testing 3632 } // namespace testing
3633 3633
3634 } // namespace about_flags 3634 } // namespace about_flags
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698