Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 280463006: Remove memory error suppressions for leaks caused by PostTaskAndReply in ImportantFileWriter. (Closed)

Created:
6 years, 7 months ago by gab
Modified:
6 years, 6 months ago
Reviewers:
robertshield
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Visibility:
Public.

Description

Remove memory error suppressions for leaks caused by PostTaskAndReply in ImportantFileWriter. Those suppressions were initially added in https://codereview.chromium.org/257003007/, but the scope of the errors was much reduced in the latest patch set where these suppressions became superfluous (since the only tests running that code path now properly flush the message queue before exiting). BUG=371974 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276697

Patch Set 1 #

Patch Set 2 : merge up to r275130 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M tools/lsan/suppressions.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
gab
Robert, PTAL. Thanks! Gab
6 years, 7 months ago (2014-05-12 20:32:03 UTC) #1
robertshield
lgtm
6 years, 7 months ago (2014-05-13 01:51:41 UTC) #2
robertshield
The CQ bit was checked by robertshield@chromium.org
6 years, 7 months ago (2014-05-13 11:37:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/280463006/1
6 years, 7 months ago (2014-05-13 11:38:09 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-13 11:50:28 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-13 11:53:02 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/67340)
6 years, 7 months ago (2014-05-13 11:53:02 UTC) #7
gab
The CQ bit was checked by gab@chromium.org
6 years, 6 months ago (2014-06-12 13:30:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/280463006/20001
6 years, 6 months ago (2014-06-12 13:31:29 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 16:14:20 UTC) #10
Message was sent while issue was closed.
Change committed as 276697

Powered by Google App Engine
This is Rietveld 408576698