Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1037)

Unified Diff: chrome/test/data/extensions/platform_apps/app_icon/test.js

Issue 2804623004: arc: Restore Chrome badging for apps that have peer in Android apps. (Closed)
Patch Set: update Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/extensions/platform_apps/app_icon/test.js
diff --git a/chrome/test/data/extensions/platform_apps/app_icon/test.js b/chrome/test/data/extensions/platform_apps/app_icon/test.js
index afb3eb88534d73078af11a162ec4e45fcc7618cd..3b3887a44de97bd77798c27b9a0e74fd15b31709 100644
--- a/chrome/test/data/extensions/platform_apps/app_icon/test.js
+++ b/chrome/test/data/extensions/platform_apps/app_icon/test.js
@@ -15,7 +15,16 @@ chrome.app.runtime.onLaunched.addListener(function() {
chrome.app.window.create(
'main.html', { type: "shell" },
function (win) {
- chrome.test.sendMessage("Completed");
+ // Create the shell window which is shown in shelf; it should use
+ // another custom app icon.
+ chrome.app.window.create(
+ 'main.html', { id: "win_with_icon",
+ type: "shell",
+ icon: "icon48.png",
msw 2017/04/06 19:22:29 q: what's the difference between |win.setIcon("...
khmel 2017/04/06 20:10:40 It is equivalent, can be used after creation. Also
+ showInShelf: true },
+ function (win) {
+ chrome.test.sendMessage("Completed");
+ });
});
});
});

Powered by Google App Engine
This is Rietveld 408576698