arc: Restore Chrome badging for apps that have peer in Android apps.

chrome/browser/ui/ash/launcher/extension_app_window_launcher_controller.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/ash/launcher/extension_app_window_launcher_controller.h"
 
 #include "ash/common/shelf/shelf_delegate.h"
 #include "ash/common/wm_window.h"
 #include "ash/shell.h"
 #include "ash/wm/window_properties.h"
@@ skipping 74 matching lines @@
   registry->AddObserver(this);
   registry_.insert(registry);
 }
 
 void ExtensionAppWindowLauncherController::OnAppWindowIconChanged(
     AppWindow* app_window) {
   const std::string app_shelf_id = GetAppShelfId(app_window);
   AppControllerMap::iterator iter = app_controller_map_.find(app_shelf_id);
   if (iter == app_controller_map_.end())
     return;
+
+  // Check if the window actually overrides its default icon. Otherwise use app
+  // icon loader provided by owner.
+  if (!app_window->HasCustomIcon() || app_window->app_icon().IsEmpty())

[msw, 2017/04/06 20:23:34]

Should HasCustomIcon also check !app_window->app_icon().IsEmpty()?

[khmel, 2017/04/06 20:39:15]

Not sure, that means custom icon is set but might be not loaded yet. I added
comment. Actually I don't have very strong opinion what is better so if you see
that is better I can change the meaning.

[msw, 2017/04/06 20:48:22]

What you have is fine for now.

+    return;
+
   ExtensionAppWindowLauncherItemController* controller = iter->second;
   controller->set_image_set_by_controller(true);
   owner()->SetLauncherItemImage(controller->shelf_id(),
                                 app_window->app_icon().AsImageSkia());
 }
 
 void ExtensionAppWindowLauncherController::OnAppWindowShown(
     AppWindow* app_window,
     bool was_hidden) {
   aura::Window* window = app_window->GetNativeWindow();
@@ skipping 70 matching lines @@
     controller->AddAppWindow(app_window);
     // If there is already a shelf id mapped to this AppLaunchId (e.g. pinned),
     // use that shelf item.
     shelf_id =
         ash::Shell::Get()->shelf_delegate()->GetShelfIDForAppIDAndLaunchID(
             app_id, launch_id);
 
     if (shelf_id == 0) {
       shelf_id = owner()->CreateAppLauncherItem(std::move(controller), status);
       // Restore any existing app icon and flag as set.
-      const gfx::Image& app_icon = app_window->app_icon();
-      if (!app_icon.IsEmpty()) {
-        owner()->SetLauncherItemImage(shelf_id, app_icon.AsImageSkia());
-        item_controller->set_image_set_by_controller(true);
+      if (app_window->HasCustomIcon() && !app_window->app_icon().IsEmpty()) {
+        const gfx::Image& app_icon = app_window->app_icon();
+        if (!app_icon.IsEmpty()) {

[msw, 2017/04/06 20:23:34]

This check is now redundant with the one on line 191.

[khmel, 2017/04/06 20:39:15]

Done.

+          owner()->SetLauncherItemImage(shelf_id, app_icon.AsImageSkia());
+          item_controller->set_image_set_by_controller(true);
+        }
       }
     } else {
       owner()->SetShelfItemDelegate(shelf_id, std::move(controller));
     }
 
     // We need to change the controller associated with app_shelf_id.
     app_controller_map_[app_shelf_id] = item_controller;
   }
   owner()->SetItemStatus(shelf_id, status);
   ash::WmWindow::Get(window)->aura_window()->SetProperty(ash::kShelfIDKey,
@@ skipping 38 matching lines @@
   WindowToAppShelfIdMap::iterator window_iter =
       window_to_app_shelf_id_map_.find(window);
   if (window_iter == window_to_app_shelf_id_map_.end())
     return nullptr;
   AppControllerMap::iterator app_controller_iter =
       app_controller_map_.find(window_iter->second);
   if (app_controller_iter == app_controller_map_.end())
     return nullptr;
   return app_controller_iter->second;
 }